From 0b860b74fb7bf68adfddc30cb4d441a173e6a4b2 Mon Sep 17 00:00:00 2001
From: Maximilian Giller <m.giller@tu-bs.de>
Date: Wed, 28 Sep 2022 02:40:50 +0200
Subject: [PATCH] Added centralized normalisation for the new space name
---
src/editor/components/spacemanager.tsx | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/src/editor/components/spacemanager.tsx b/src/editor/components/spacemanager.tsx
index 76ed708..eb391d7 100644
--- a/src/editor/components/spacemanager.tsx
+++ b/src/editor/components/spacemanager.tsx
@@ -27,8 +27,9 @@ function SpaceManager({
onDeleteSpace(spaceId);
};
+ const normalizedNewSpaceName = () => newSpaceName.trim();
const isSpaceCreationAllowed = () =>
- newSpaceName.length === 0 || spaces.includes(newSpaceName.trim());
+ newSpaceName.length === 0 || spaces.includes(normalizedNewSpaceName());
return (
<div id="space-manager">
@@ -45,25 +46,28 @@ function SpaceManager({
<li>
<button
disabled={isSpaceCreationAllowed()}
- onClick={() => onRenameSpace(newSpaceName)}
+ onClick={() => onRenameSpace(normalizedNewSpaceName())}
>
- Rename to {'"' + newSpaceName + '"'}
+ Rename to {'"' + normalizedNewSpaceName() + '"'}
</button>
</li>
<li>
<button
disabled={isSpaceCreationAllowed()}
- onClick={() => onDuplicateSpace(newSpaceName)}
+ onClick={() =>
+ onDuplicateSpace(normalizedNewSpaceName())
+ }
>
- Duplicate as {'"' + newSpaceName + '"'}
+ Duplicate as {'"' + normalizedNewSpaceName() + '"'}
</button>
</li>
<li>
<button
disabled={isSpaceCreationAllowed()}
- onClick={() => onCreateSpace(newSpaceName)}
+ onClick={() => onCreateSpace(normalizedNewSpaceName())}
>
- Create empty graph {'"' + newSpaceName + '"'}
+ Create empty graph{" "}
+ {'"' + normalizedNewSpaceName() + '"'}
</button>
</li>
</ul>
--
GitLab