From 109f6ce59493b6c0d7c11e6592dc0abb8bcba96e Mon Sep 17 00:00:00 2001
From: Harm Kube <h.kube@tu-braunschweig.de>
Date: Sun, 20 Feb 2022 16:40:23 +0100
Subject: [PATCH] Improving performance by not iterating over all pages
---
display/overlays/neighbors.js | 27 ++++++++++++---------------
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/display/overlays/neighbors.js b/display/overlays/neighbors.js
index ba682f6..2ec1420 100644
--- a/display/overlays/neighbors.js
+++ b/display/overlays/neighbors.js
@@ -193,22 +193,19 @@ class NodeNeighborOverlay {
}
toggleCategory (type) {
- for (const page of Object.values(this.tabContentPages)) {
- if(page.type == type) {
- if(this.tabNavHandles[page.type].style.display == "flex") {
- this.tabNavHandles[page.type].style.display = "none";
- const collTabContent = this.tabContentPages[page.type];
- jQuery(collTabContent).slideUp("fast");
- collTabContent.marker.innerText = '+';
+ const page = this.tabContentPages[type];
+ if (this.tabNavHandles[page.type].style.display == "flex") {
+ this.tabNavHandles[page.type].style.display = "none";
+ const collTabContent = this.tabContentPages[page.type];
+ jQuery(collTabContent).slideUp("fast");
+ collTabContent.marker.innerText = '+';
+ } else {
+ if (page.list.hasChildNodes()) {
+ this.tabNavHandles[page.type].style.display = "flex";
+ if (this.tabContentPages[page.type].style.display == "flex") {
+ this.tabNavHandles[page.type].marker.innerText = '-';
} else {
- if(page.list.hasChildNodes()) {
- this.tabNavHandles[page.type].style.display = "flex";
- if (this.tabContentPages[page.type].style.display == "flex") {
- this.tabNavHandles[page.type].marker.innerText = '-';
- } else {
- this.tabNavHandles[page.type].marker.innerText = '+';
- }
- }
+ this.tabNavHandles[page.type].marker.innerText = '+';
}
}
}
--
GitLab