From 323a38819a3da43924c0f50cfab7ccfe82e4565e Mon Sep 17 00:00:00 2001 From: Simon Brummer <simon.brummer@posteo.de> Date: Sun, 10 Jun 2018 17:01:05 +0200 Subject: [PATCH] native: Enforce safe strncpy usage in tap device setup --- cpu/native/netdev_tap/netdev_tap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpu/native/netdev_tap/netdev_tap.c b/cpu/native/netdev_tap/netdev_tap.c index e686093a5f..616fd32ad1 100644 --- a/cpu/native/netdev_tap/netdev_tap.c +++ b/cpu/native/netdev_tap/netdev_tap.c @@ -300,7 +300,8 @@ static int _send(netdev_t *netdev, const iolist_t *iolist) void netdev_tap_setup(netdev_tap_t *dev, const netdev_tap_params_t *params) { dev->netdev.driver = &netdev_driver_tap; - strncpy(dev->tap_name, *(params->tap_name), IFNAMSIZ); + strncpy(dev->tap_name, *(params->tap_name), IFNAMSIZ - 1); + dev->tap_name[IFNAMSIZ - 1] = '\0'; } static void _tap_isr(int fd, void *arg) { -- GitLab