From 8a1a2b41fb65c9e55e4204af7a634fb85c85160d Mon Sep 17 00:00:00 2001
From: Ken Bannister <kb2ma@runbox.com>
Date: Wed, 16 Jan 2019 05:38:13 -0500
Subject: [PATCH] examples/gcoap: handle request buffer too small
---
examples/gcoap/gcoap_cli.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/examples/gcoap/gcoap_cli.c b/examples/gcoap/gcoap_cli.c
index 0d917c736b..74e4ac0603 100644
--- a/examples/gcoap/gcoap_cli.c
+++ b/examples/gcoap/gcoap_cli.c
@@ -243,7 +243,14 @@ int gcoap_cli_cmd(int argc, char **argv)
((argc == apos + 4) && (code_pos != 0))) {
gcoap_req_init(&pdu, &buf[0], GCOAP_PDU_BUF_SIZE, code_pos+1, argv[apos+2]);
if (argc == apos + 4) {
- memcpy(pdu.payload, argv[apos+3], strlen(argv[apos+3]));
+ /* must be 'greater than' to account for payload marker byte */
+ if (pdu.payload_len > strlen(argv[apos+3])) {
+ memcpy(pdu.payload, argv[apos+3], strlen(argv[apos+3]));
+ }
+ else {
+ puts("gcoap_cli: msg buffer too small");
+ return 1;
+ }
}
coap_hdr_set_type(pdu.hdr, msg_type);
--
GitLab