From 9103dcaeda7b10b2a8cdda318aeb0de7c29e9897 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABtan=20Harter?= <gaetan.harter@fu-berlin.de> Date: Tue, 5 Jun 2018 13:32:51 +0200 Subject: [PATCH] cortexm_common: refactor the definition test The variables should all always be defined. --- cpu/cortexm_common/Makefile.include | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cpu/cortexm_common/Makefile.include b/cpu/cortexm_common/Makefile.include index 65463a1859..d7150d2cdb 100644 --- a/cpu/cortexm_common/Makefile.include +++ b/cpu/cortexm_common/Makefile.include @@ -6,7 +6,13 @@ ifneq (,$(ROM_OFFSET)) LINKFLAGS += $(LINKFLAGPREFIX)--defsym=_rom_offset=$(ROM_OFFSET) endif +# All variables must be defined in the CPU configuration when using the common +# `ldscripts/cortexm.ld` ifneq (,$(ROM_START_ADDR)$(RAM_START_ADDR)$(ROM_LEN)$(RAM_LEN)) + $(if $(ROM_START_ADDR),,$(error ROM_START_ADDR is not defined)) + $(if $(RAM_START_ADDR),,$(error RAM_START_ADDR is not defined)) + $(if $(ROM_LEN),,$(error ROM_LEN is not defined)) + $(if $(RAM_LEN),,$(error RAM_LEN is not defined)) LINKFLAGS += $(LINKFLAGPREFIX)--defsym=_rom_start_addr=$(ROM_START_ADDR) LINKFLAGS += $(LINKFLAGPREFIX)--defsym=_ram_start_addr=$(RAM_START_ADDR) LINKFLAGS += $(LINKFLAGPREFIX)--defsym=_rom_length=$(ROM_LEN) -- GitLab