diff --git a/cpu/x86/x86_memory.c b/cpu/x86/x86_memory.c index d2a4117d52247f175b7b048980a20c554d52cef2..a1a2b6b190efa8e389ef1a5a3a1f225052a01ae1 100644 --- a/cpu/x86/x86_memory.c +++ b/cpu/x86/x86_memory.c @@ -76,6 +76,8 @@ void x86_init_gdt(void) .limit_16_19_and_flags = 0, .base_24_31 = 0, }, + /* cppcheck-suppress duplicateExpression + * it's for consistent look & feel */ [0x0008 / 8] = { .limit_0_15 = 0xFFFF, .base_0_15 = 0, diff --git a/cpu/x86/x86_pci.c b/cpu/x86/x86_pci.c index 706af0ba93320f67f3f4bbc4dad3a4cb52917c6d..9eabdf7790a6436d81a8dc751190adb0e6bd30f9 100644 --- a/cpu/x86/x86_pci.c +++ b/cpu/x86/x86_pci.c @@ -181,7 +181,7 @@ static void pci_setup_ios(struct x86_known_pci_device *dev) printf(" BAR %u: memory, physical = 0x%08x-0x%08x, virtual = 0x%08x-0x%08x\n", bar_num, physical_start, physical_start + length - 1, - (unsigned) ptr, (uintptr_t) ptr + length - 1); + (unsigned) ptr, (unsigned) ((uintptr_t) ptr + length - 1)); } } } diff --git a/cpu/x86/x86_pit.c b/cpu/x86/x86_pit.c index dfa77b578fbd02cb924d544cd380670135408da6..32984dd47aaec4bceadf9ad09507d9d49c99b2c9 100644 --- a/cpu/x86/x86_pit.c +++ b/cpu/x86/x86_pit.c @@ -55,7 +55,7 @@ void x86_pit_set2(unsigned channel, unsigned mode, uint16_t max) { unsigned old_flags = irq_disable(); outb(PIT_COMMAND_PORT, ((channel - 1) << 6) | mode | PIT_ACCESS_MODE_LO_HI); - outb(PIT_CHANNEL_0_PORT + channel - 1, max && 0xff); + outb(PIT_CHANNEL_0_PORT + channel - 1, max & 0xff); outb(PIT_CHANNEL_0_PORT + channel - 1, max >> 8); irq_restore(old_flags); }