diff --git a/examples/gnrc_networking/udp.c b/examples/gnrc_networking/udp.c index 7d8153465d5bdd9c314616b3cb226f6b9770e346..9fe7004a6639175c2f64c1202be7d2275cbfb7fa 100644 --- a/examples/gnrc_networking/udp.c +++ b/examples/gnrc_networking/udp.c @@ -65,7 +65,7 @@ static void send(char *addr_str, char *port_str, char *data, unsigned int num, return; } /* allocate IPv6 header */ - ip = gnrc_ipv6_hdr_build(udp, NULL, (uint8_t *)&addr); + ip = gnrc_ipv6_hdr_build(udp, NULL, &addr); if (ip == NULL) { puts("Error: unable to allocate IPv6 header"); gnrc_pktbuf_release(udp); diff --git a/sys/include/net/gnrc/ipv6/hdr.h b/sys/include/net/gnrc/ipv6/hdr.h index d7af9574c2d614817954da545d6b0a59176c760c..638c1fc5bffc5990c6d04b98ec109f2ae48f30af 100644 --- a/sys/include/net/gnrc/ipv6/hdr.h +++ b/sys/include/net/gnrc/ipv6/hdr.h @@ -43,8 +43,8 @@ extern "C" { * @return The an IPv6 header in packet buffer on success. * @return NULL on error. */ -gnrc_pktsnip_t *gnrc_ipv6_hdr_build(gnrc_pktsnip_t *payload, uint8_t *src, - uint8_t *dst); +gnrc_pktsnip_t *gnrc_ipv6_hdr_build(gnrc_pktsnip_t *payload, ipv6_addr_t *src, + ipv6_addr_t *dst); #ifdef __cplusplus } diff --git a/sys/net/gnrc/application_layer/tftp/gnrc_tftp.c b/sys/net/gnrc/application_layer/tftp/gnrc_tftp.c index 16b01c66a90c4b05964105631f85c153d9eb7af4..6feaf4b4c3fda8ccde3029c21ab5b870c6acd70f 100644 --- a/sys/net/gnrc/application_layer/tftp/gnrc_tftp.c +++ b/sys/net/gnrc/application_layer/tftp/gnrc_tftp.c @@ -971,7 +971,7 @@ tftp_state _tftp_send(gnrc_pktsnip_t *buf, tftp_context_t *ctxt, size_t len) } /* allocate IPv6 header */ - ip = gnrc_ipv6_hdr_build(udp, NULL, ctxt->peer.u8); + ip = gnrc_ipv6_hdr_build(udp, NULL, &(ctxt->peer)); if (ip == NULL) { DEBUG("tftp: error unable to allocate IPv6 header"); gnrc_pktbuf_release(udp); diff --git a/sys/net/gnrc/application_layer/zep/gnrc_zep.c b/sys/net/gnrc/application_layer/zep/gnrc_zep.c index d351811939bf3af0240575d0e3c80b0756e80ab2..c6228f58a63d5decfc9c2df53bda6a9e4126cb94 100644 --- a/sys/net/gnrc/application_layer/zep/gnrc_zep.c +++ b/sys/net/gnrc/application_layer/zep/gnrc_zep.c @@ -241,7 +241,7 @@ static int _send(gnrc_netdev_t *netdev, gnrc_pktsnip_t *pkt) new_pkt = hdr; - hdr = gnrc_ipv6_hdr_build(new_pkt, NULL, (uint8_t *) &(dev->dst)); + hdr = gnrc_ipv6_hdr_build(new_pkt, NULL, &(dev->dst)); if (hdr == NULL) { DEBUG("zep: could not allocate IPv6 header in pktbuf\n"); diff --git a/sys/net/gnrc/conn/ip/gnrc_conn_ip.c b/sys/net/gnrc/conn/ip/gnrc_conn_ip.c index 66a5bd0cc707c5277ebeed5a48534c65324e0cbc..b2311b7b2e097260e2c7e2fa34bea4f40f3f243a 100644 --- a/sys/net/gnrc/conn/ip/gnrc_conn_ip.c +++ b/sys/net/gnrc/conn/ip/gnrc_conn_ip.c @@ -99,7 +99,7 @@ int conn_ip_sendto(const void *data, size_t len, const void *src, size_t src_len return -EINVAL; } /* addr will only be copied */ - hdr = gnrc_ipv6_hdr_build(pkt, (uint8_t *)src, (uint8_t *)dst); + hdr = gnrc_ipv6_hdr_build(pkt, src, dst); if (hdr == NULL) { gnrc_pktbuf_release(pkt); return -ENOMEM; diff --git a/sys/net/gnrc/conn/udp/gnrc_conn_udp.c b/sys/net/gnrc/conn/udp/gnrc_conn_udp.c index 2e0c3b9c73553c68c4d20a8acee09ed727a6ce59..fc18a950ced8458b1b885d8d121cf06607182c29 100644 --- a/sys/net/gnrc/conn/udp/gnrc_conn_udp.c +++ b/sys/net/gnrc/conn/udp/gnrc_conn_udp.c @@ -111,7 +111,7 @@ int conn_udp_sendto(const void *data, size_t len, const void *src, size_t src_le return -EINVAL; } /* addr will only be copied */ - hdr = gnrc_ipv6_hdr_build(pkt, (uint8_t *)src, (uint8_t *)dst); + hdr = gnrc_ipv6_hdr_build(pkt, src, dst); if (hdr == NULL) { gnrc_pktbuf_release(pkt); return -ENOMEM; diff --git a/sys/net/gnrc/netreg/gnrc_netreg.c b/sys/net/gnrc/netreg/gnrc_netreg.c index 11d0d6ae8a8bd7e81c66adf055c625a5fc947b12..b81de9b01f11b70ffd63d816b89f638bbe4cc407 100644 --- a/sys/net/gnrc/netreg/gnrc_netreg.c +++ b/sys/net/gnrc/netreg/gnrc_netreg.c @@ -146,7 +146,7 @@ gnrc_pktsnip_t *gnrc_netreg_hdr_build(gnrc_nettype_t type, gnrc_pktsnip_t *paylo case GNRC_NETTYPE_IPV6: assert(src_len == sizeof(ipv6_addr_t)); assert(dst_len == sizeof(ipv6_addr_t)); - return gnrc_ipv6_hdr_build(payload, src, dst); + return gnrc_ipv6_hdr_build(payload, (ipv6_addr_t*) src, (ipv6_addr_t*) dst); #endif #ifdef MODULE_GNRC_TCP diff --git a/sys/net/gnrc/network_layer/icmpv6/echo/gnrc_icmpv6_echo.c b/sys/net/gnrc/network_layer/icmpv6/echo/gnrc_icmpv6_echo.c index 47a5316146a9efe2841f3502752666779d80074c..3d2ecd90657f8bb842b2aa1344433b16a7a8f107 100644 --- a/sys/net/gnrc/network_layer/icmpv6/echo/gnrc_icmpv6_echo.c +++ b/sys/net/gnrc/network_layer/icmpv6/echo/gnrc_icmpv6_echo.c @@ -84,11 +84,10 @@ void gnrc_icmpv6_echo_req_handle(kernel_pid_t iface, ipv6_hdr_t *ipv6_hdr, } if (ipv6_addr_is_multicast(&ipv6_hdr->dst)) { - hdr = gnrc_ipv6_hdr_build(pkt, NULL, (uint8_t *)&ipv6_hdr->src); + hdr = gnrc_ipv6_hdr_build(pkt, NULL, &ipv6_hdr->src); } else { - hdr = gnrc_ipv6_hdr_build(pkt, (uint8_t *)&ipv6_hdr->dst, - (uint8_t *)&ipv6_hdr->src); + hdr = gnrc_ipv6_hdr_build(pkt, &ipv6_hdr->dst, &ipv6_hdr->src); } if (hdr == NULL) { diff --git a/sys/net/gnrc/network_layer/ipv6/hdr/gnrc_ipv6_hdr.c b/sys/net/gnrc/network_layer/ipv6/hdr/gnrc_ipv6_hdr.c index 53808f3921d5b093e83da0cde56fa705bcf2c916..d467937c3842808efbc98d2bd267689ba3103c30 100644 --- a/sys/net/gnrc/network_layer/ipv6/hdr/gnrc_ipv6_hdr.c +++ b/sys/net/gnrc/network_layer/ipv6/hdr/gnrc_ipv6_hdr.c @@ -32,8 +32,8 @@ static char addr_str[IPV6_ADDR_MAX_STR_LEN]; #define HDR_NETTYPE (GNRC_NETTYPE_UNDEF) #endif -gnrc_pktsnip_t *gnrc_ipv6_hdr_build(gnrc_pktsnip_t *payload, uint8_t *src, - uint8_t *dst) +gnrc_pktsnip_t *gnrc_ipv6_hdr_build(gnrc_pktsnip_t *payload, ipv6_addr_t *src, + ipv6_addr_t *dst) { gnrc_pktsnip_t *ipv6; ipv6_hdr_t *hdr; diff --git a/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c b/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c index 49f2a67e79e1eef1f95fb145a89bebb2c6a0a2af..a65ad2acd00300d72c1c05102f8b9590b19abd0b 100644 --- a/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c +++ b/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c @@ -837,8 +837,7 @@ static gnrc_pktsnip_t *_build_headers(kernel_pid_t iface, gnrc_pktsnip_t *payloa ipv6_addr_t *dst, ipv6_addr_t *src) { gnrc_pktsnip_t *l2hdr; - gnrc_pktsnip_t *iphdr = gnrc_ipv6_hdr_build(payload, (uint8_t *)src, - (uint8_t *)dst); + gnrc_pktsnip_t *iphdr = gnrc_ipv6_hdr_build(payload, src, dst); if (iphdr == NULL) { DEBUG("ndp internal: error allocating IPv6 header.\n"); return NULL; diff --git a/sys/net/gnrc/routing/rpl/gnrc_rpl_control_messages.c b/sys/net/gnrc/routing/rpl/gnrc_rpl_control_messages.c index 9d8871c3520386e69a90db51b7d5ee8fb63e7809..573b71d7fd26c97fb5b44705d19cf53194c61860 100644 --- a/sys/net/gnrc/routing/rpl/gnrc_rpl_control_messages.c +++ b/sys/net/gnrc/routing/rpl/gnrc_rpl_control_messages.c @@ -77,7 +77,7 @@ void gnrc_rpl_send(gnrc_pktsnip_t *pkt, kernel_pid_t iface, ipv6_addr_t *src, ip dst = (ipv6_addr_t *) &ipv6_addr_all_rpl_nodes; } - hdr = gnrc_ipv6_hdr_build(pkt, (uint8_t *)src, (uint8_t *)dst); + hdr = gnrc_ipv6_hdr_build(pkt, src, dst); if (hdr == NULL) { DEBUG("RPL: Send - no space left in packet buffer\n"); diff --git a/sys/shell/commands/sc_icmpv6_echo.c b/sys/shell/commands/sc_icmpv6_echo.c index e8d67483f22c7ab2b5d4e5085ea59531070af180..0aab0113dc81bd60e84bdd0a64a577aaf5c91548 100644 --- a/sys/shell/commands/sc_icmpv6_echo.c +++ b/sys/shell/commands/sc_icmpv6_echo.c @@ -254,7 +254,7 @@ int _icmpv6_ping(int argc, char **argv) _set_payload(pkt->data, payload_len); - pkt = gnrc_ipv6_hdr_build(pkt, NULL, addr.u8); + pkt = gnrc_ipv6_hdr_build(pkt, NULL, &addr); if (pkt == NULL) { puts("error: packet buffer full"); diff --git a/tests/unittests/tests-gnrc_ipv6_hdr/tests-gnrc_ipv6_hdr.c b/tests/unittests/tests-gnrc_ipv6_hdr/tests-gnrc_ipv6_hdr.c index 485579095a0d4a44ee368603d73d10fe02c490d4..5440ac1925d3ac13dab6ae54d5d792a55745b882 100644 --- a/tests/unittests/tests-gnrc_ipv6_hdr/tests-gnrc_ipv6_hdr.c +++ b/tests/unittests/tests-gnrc_ipv6_hdr/tests-gnrc_ipv6_hdr.c @@ -42,7 +42,7 @@ static void test_gnrc_ipv6_hdr_build__src_NULL(void) ipv6_hdr_t *hdr; gnrc_pktbuf_init(); - TEST_ASSERT_NOT_NULL(pkt = gnrc_ipv6_hdr_build(NULL, NULL, (uint8_t *)&dst)); + TEST_ASSERT_NOT_NULL(pkt = gnrc_ipv6_hdr_build(NULL, NULL, &dst)); hdr = pkt->data; TEST_ASSERT_NOT_NULL(hdr); TEST_ASSERT(ipv6_hdr_is(hdr)); @@ -61,7 +61,7 @@ static void test_gnrc_ipv6_hdr_build__dst_NULL(void) ipv6_hdr_t *hdr; gnrc_pktbuf_init(); - TEST_ASSERT_NOT_NULL(pkt = gnrc_ipv6_hdr_build(NULL, (uint8_t *)&src, NULL)); + TEST_ASSERT_NOT_NULL(pkt = gnrc_ipv6_hdr_build(NULL, &src, NULL)); hdr = pkt->data; TEST_ASSERT_NOT_NULL(hdr); TEST_ASSERT(ipv6_hdr_is(hdr)); @@ -81,7 +81,7 @@ static void test_gnrc_ipv6_hdr_build__complete(void) ipv6_hdr_t *hdr; gnrc_pktbuf_init(); - TEST_ASSERT_NOT_NULL(pkt = gnrc_ipv6_hdr_build(NULL, (uint8_t *)&src, (uint8_t *)&dst)); + TEST_ASSERT_NOT_NULL(pkt = gnrc_ipv6_hdr_build(NULL, &src, &dst)); hdr = pkt->data; TEST_ASSERT_NOT_NULL(hdr); TEST_ASSERT(ipv6_hdr_is(hdr));