From a7a8227e36c74ce10386d7a6bd39ccb862e0dfcf Mon Sep 17 00:00:00 2001
From: Martine Lenders <m.lenders@fu-berlin.de>
Date: Wed, 14 Nov 2018 14:29:21 +0100
Subject: [PATCH] gnrc_icmpv6_error: centralize send function
---
.../icmpv6/error/gnrc_icmpv6_error.c | 23 +++++++++----------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/sys/net/gnrc/network_layer/icmpv6/error/gnrc_icmpv6_error.c b/sys/net/gnrc/network_layer/icmpv6/error/gnrc_icmpv6_error.c
index eb58422518..41dc9730f8 100644
--- a/sys/net/gnrc/network_layer/icmpv6/error/gnrc_icmpv6_error.c
+++ b/sys/net/gnrc/network_layer/icmpv6/error/gnrc_icmpv6_error.c
@@ -122,23 +122,26 @@ static gnrc_pktsnip_t *_param_prob_build(uint8_t code, void *ptr,
return pkt;
}
-void gnrc_icmpv6_error_dst_unr_send(uint8_t code, const gnrc_pktsnip_t *orig_pkt)
+static void _send(gnrc_pktsnip_t *pkt)
{
- gnrc_pktsnip_t *pkt = _dst_unr_build(code, orig_pkt);
-
if (pkt != NULL) {
gnrc_netapi_send(gnrc_ipv6_pid, pkt);
}
}
+void gnrc_icmpv6_error_dst_unr_send(uint8_t code, const gnrc_pktsnip_t *orig_pkt)
+{
+ gnrc_pktsnip_t *pkt = _dst_unr_build(code, orig_pkt);
+
+ _send(pkt);
+}
+
void gnrc_icmpv6_error_pkt_too_big_send(uint32_t mtu,
const gnrc_pktsnip_t *orig_pkt)
{
gnrc_pktsnip_t *pkt = _pkt_too_big_build(mtu, orig_pkt);
- if (pkt != NULL) {
- gnrc_netapi_send(gnrc_ipv6_pid, pkt);
- }
+ _send(pkt);
}
void gnrc_icmpv6_error_time_exc_send(uint8_t code,
@@ -146,9 +149,7 @@ void gnrc_icmpv6_error_time_exc_send(uint8_t code,
{
gnrc_pktsnip_t *pkt = _time_exc_build(code, orig_pkt);
- if (pkt != NULL) {
- gnrc_netapi_send(gnrc_ipv6_pid, pkt);
- }
+ _send(pkt);
}
void gnrc_icmpv6_error_param_prob_send(uint8_t code, void *ptr,
@@ -156,9 +157,7 @@ void gnrc_icmpv6_error_param_prob_send(uint8_t code, void *ptr,
{
gnrc_pktsnip_t *pkt = _param_prob_build(code, ptr, orig_pkt);
- if (pkt != NULL) {
- gnrc_netapi_send(gnrc_ipv6_pid, pkt);
- }
+ _send(pkt);
}
/** @} */
--
GitLab