From b34dc3a565b5ee2cb09ea6480bee92582fa619bb Mon Sep 17 00:00:00 2001
From: Juan Carrano <j.carrano@fu-berlin.de>
Date: Tue, 18 Dec 2018 14:49:28 +0100
Subject: [PATCH] sys/shell: ensure character is flushed when echoing.
When using a serial terminal without local echo, the current line
would not get updated as the user typed because the shell module's
readline() was not flushing each character.
This commit fixes that behavior. For additional clarity, fflush is
turned into a macro (flush_if_needed) which expands to either a call
to fflush() or empty, according to the standard library used.
This also fixes the erase/line editing behavior (the delete characters
were not being flushed either.)
---
sys/shell/shell.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/sys/shell/shell.c b/sys/shell/shell.c
index bb4ec74ecc..880d320b0f 100644
--- a/sys/shell/shell.c
+++ b/sys/shell/shell.c
@@ -44,6 +44,13 @@ static void _putchar(int c) {
#endif
#endif
+static void flush_if_needed(void)
+{
+#ifdef MODULE_NEWLIB
+ fflush(stdout);
+#endif
+}
+
static shell_command_handler_t find_handler(const shell_command_t *command_list, char *command)
{
const shell_command_t *command_lists[] = {
@@ -265,6 +272,7 @@ static int readline(char *buf, size_t size)
_putchar(c);
#endif
}
+ flush_if_needed();
}
}
@@ -275,9 +283,7 @@ static inline void print_prompt(void)
_putchar(' ');
#endif
-#ifdef MODULE_NEWLIB
- fflush(stdout);
-#endif
+ flush_if_needed();
}
void shell_run(const shell_command_t *shell_commands, char *line_buf, int len)
--
GitLab