From d7942cd974f813519933b162bc5594ddf5f28454 Mon Sep 17 00:00:00 2001
From: smlng <s@mlng.net>
Date: Fri, 21 Sep 2018 10:39:22 +0200
Subject: [PATCH] dist/tools: fix tunslip6 strncat num param
Cppcheck was (correctly) warning here that concat to strings might
result in buffer overflow because the terminating `\0` was not considered.
This is fixed here, making the cppcheck suppression also obsolete.
---
dist/tools/tunslip/tunslip6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dist/tools/tunslip/tunslip6.c b/dist/tools/tunslip/tunslip6.c
index b77958845e..19c9074273 100644
--- a/dist/tools/tunslip/tunslip6.c
+++ b/dist/tools/tunslip/tunslip6.c
@@ -651,7 +651,7 @@ devopen(const char *dev, int flags)
char t[1024];
strcpy(t, "/dev/");
/* cppcheck-suppress bufferAccessOutOfBounds
- * reason: seems to be a cppcheck bug */
+ * (reason: seems to be a bug in cppcheck 1.7x) */
strncat(t, dev, sizeof(t) - 5);
return open(t, flags);
}
--
GitLab