From d8e2611ed95b6ded088ffa375acd67cfe1f039e4 Mon Sep 17 00:00:00 2001 From: smlng <s@mlng.net> Date: Fri, 3 Aug 2018 15:15:59 +0200 Subject: [PATCH] cpu/cc2538: refine gpio_init_mux Introduces a define to inidicate an unused function parameter. --- cpu/cc2538/include/periph_cpu.h | 4 ++++ cpu/cc2538/periph/gpio.c | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/cpu/cc2538/include/periph_cpu.h b/cpu/cc2538/include/periph_cpu.h index 6ebce4cc6f..05e819065a 100644 --- a/cpu/cc2538/include/periph_cpu.h +++ b/cpu/cc2538/include/periph_cpu.h @@ -60,6 +60,10 @@ typedef uint32_t gpio_t; */ #define GPIO_UNDEF (0xffffffff) +/** + * @brief Custom value to indicate unused parameter in gpio_init_mux + */ +#define GPIO_MUX_NONE (0xff) /** * @brief Define a custom GPIO_PIN macro * diff --git a/cpu/cc2538/periph/gpio.c b/cpu/cc2538/periph/gpio.c index 0dc3f2ef9b..f9196ed0b6 100644 --- a/cpu/cc2538/periph/gpio.c +++ b/cpu/cc2538/periph/gpio.c @@ -264,13 +264,13 @@ void gpio_init_mux(gpio_t pin, uint8_t over, uint8_t sel, uint8_t func) { assert(pin != GPIO_UNDEF); /* configure pin function and multiplexing */ - if (over != MODE_NOTSUP) { + if (over != GPIO_MUX_NONE) { IOC->OVER[_pp_num(pin)] = over; } - if (sel != MODE_NOTSUP) { + if (sel != GPIO_MUX_NONE) { IOC->SEL[_pp_num(pin)] = sel; } - if (func != MODE_NOTSUP) { + if (func != GPIO_MUX_NONE) { IOC->PINS[func] = _pp_num(pin); } /* enable alternative function mode */ -- GitLab