From fb393905dda647b4bb5140166f739dce949c68b4 Mon Sep 17 00:00:00 2001
From: Vincent Dupont <vincent@otakeys.com>
Date: Mon, 8 Jan 2018 18:07:31 +0100
Subject: [PATCH] can: fix fall through error
---
sys/can/conn/isotp.c | 2 +-
sys/can/isotp/isotp.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/sys/can/conn/isotp.c b/sys/can/conn/isotp.c
index 04468d7c50..bd3516292f 100644
--- a/sys/can/conn/isotp.c
+++ b/sys/can/conn/isotp.c
@@ -174,7 +174,7 @@ int conn_can_isotp_send(conn_can_isotp_t *conn, const void *buf, size_t size, in
if (msg.content.ptr == conn) {
ret = -EIO;
}
- /* No break */
+ /* Fall through */
case CAN_MSG_TX_CONFIRMATION:
#ifdef MODULE_CONN_CAN_ISOTP_MULTI
if (msg.content.ptr != conn) {
diff --git a/sys/can/isotp/isotp.c b/sys/can/isotp/isotp.c
index d3958f8923..319ce09141 100644
--- a/sys/can/isotp/isotp.c
+++ b/sys/can/isotp/isotp.c
@@ -609,6 +609,7 @@ static void _isotp_rx_timeout_task(struct isotp *isotp)
case ISOTP_SENDING_FC:
DEBUG("_isotp_rx_timeout_task: FC tx conf timeout\n");
raw_can_abort(isotp->entry.ifnum, isotp->rx.tx_handle);
+ /* Fall through */
case ISOTP_WAIT_CF:
DEBUG("_isotp_rx_timeout_task: free rx buf\n");
gnrc_pktbuf_release(isotp->rx.snip);
--
GitLab