From 78bbb2b1a31b2683044524e36b0752602861e9c5 Mon Sep 17 00:00:00 2001 From: Boris Grozev <boris@jitsi.org> Date: Wed, 25 Jun 2014 11:15:39 +0200 Subject: [PATCH] Sends FIR messages on all streams (temporary). --- .../translator/RTCPFeedbackMessageSender.java | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/org/jitsi/impl/neomedia/rtp/translator/RTCPFeedbackMessageSender.java b/src/org/jitsi/impl/neomedia/rtp/translator/RTCPFeedbackMessageSender.java index 27527e44..eebf9415 100644 --- a/src/org/jitsi/impl/neomedia/rtp/translator/RTCPFeedbackMessageSender.java +++ b/src/org/jitsi/impl/neomedia/rtp/translator/RTCPFeedbackMessageSender.java @@ -88,19 +88,17 @@ public boolean sendFIR(MediaStream destination, int[] mediaSenderSSRCs) public boolean sendFIR(int mediaSenderSSRC) { boolean sentFIR = false; - + /* + * XXX Currently this methond results in a FIR message being effectively + * broadcast (sent to all streams connected to the translator). This + * is because the MediaStreams' getRemoteSourceIds returns an empty list + * (possibly due to RED being used). + */ for (StreamRTPManager streamRTPManager : rtpTranslator.getStreamRTPManagers()) { MediaStream stream = streamRTPManager.getMediaStream(); - for (long streamSSRC : stream.getRemoteSourceIDs()) - { - if (streamSSRC == (0xffffffffL & mediaSenderSSRC)) - { - sentFIR |= sendFIR(stream, mediaSenderSSRC); - break; - } - } + sentFIR |= sendFIR(stream, mediaSenderSSRC); } return sentFIR; -- GitLab