From a462eda5e23d563e29116e1d578ccd20ce8fff5a Mon Sep 17 00:00:00 2001
From: Lyubomir Marinov <lyubomir.marinov@jitsi.org>
Date: Thu, 20 Sep 2012 12:45:00 +0000
Subject: [PATCH] Addresses incorrect and incomplete descriptions and
documentation regarding libjitsi's examples. Reported by Alexander Fedulov.
---
src/org/jitsi/examples/AVReceive2.java | 29 ++++++++++---------------
src/org/jitsi/examples/AVTransmit2.java | 29 ++++++++++++-------------
2 files changed, 26 insertions(+), 32 deletions(-)
diff --git a/src/org/jitsi/examples/AVReceive2.java b/src/org/jitsi/examples/AVReceive2.java
index b0639b71..d018bec3 100644
--- a/src/org/jitsi/examples/AVReceive2.java
+++ b/src/org/jitsi/examples/AVReceive2.java
@@ -295,28 +295,23 @@ private void close()
= {
{
LOCAL_PORT_BASE_ARG_NAME,
- "The port which is the source of the transmission"
- + " i.e. from which the media is to be transmitted."
- + " The specified value will be used as the port to"
- + " transmit the audio RTP from, the next port after it"
- + " will be used to transmit the audio RTCP from."
- + " Respectively, the subsequent ports will be used to"
- + " transmit the video RTP and RTCP from."
+ "The port on which media is to be received. The specified value"
+ + " will be used as the port to receive the audio RTP on,"
+ + " the next port after it will be used to receive the"
+ + " audio RTCP on. Respectively, the subsequent ports will"
+ + " be used to receive the video RTP and RTCP on."
},
{
REMOTE_HOST_ARG_NAME,
- "The name of the host which is the target of the transmission"
- + " i.e. to which the media is to be transmitted"
+ "The name of the host from which the media is to be received."
},
{
REMOTE_PORT_BASE_ARG_NAME,
- "The port which is the target of the transmission"
- + " i.e. to which the media is to be transmitted."
- + " The specified value will be used as the port to"
- + " transmit the audio RTP to, the next port after it"
- + " will be used to transmit the audio RTCP to."
- + " Respectively, the subsequent ports will be used to"
- + " transmit the video RTP and RTCP to."
+ "The port from which media is to be received. The specified"
+ + " vaue will be used as the port to receive the audio RTP"
+ + " from, the next port after it will be used to receive"
+ + " the audio RTCP from. Respectively, the subsequent ports"
+ + " will be used to receive the video RTP and RTCP from."
}
};
@@ -324,7 +319,7 @@ public static void main(String[] args)
throws Exception
{
// We need three parameters to do the transmission. For example,
- // java org.jitsi.examples.AVReceive2 --local-port-base=10000 --remote-host=129.130.131.132 --remote-port-base=5000
+ // ant run-example -Drun.example.name=AVReceive2 -Drun.example.arg.line="--local-port-base=10000 --remote-host=129.130.131.132 --remote-port-base=5000"
if (args.length < 3)
{
prUsage();
diff --git a/src/org/jitsi/examples/AVTransmit2.java b/src/org/jitsi/examples/AVTransmit2.java
index 558a5ca8..b2dd65b3 100644
--- a/src/org/jitsi/examples/AVTransmit2.java
+++ b/src/org/jitsi/examples/AVTransmit2.java
@@ -292,13 +292,13 @@ private void stop()
= {
{
LOCAL_PORT_BASE_ARG_NAME,
- "The port which is the source of the transmission"
- + " i.e. from which the media is to be transmitted."
- + " The specified value will be used as the port to"
- + " transmit the audio RTP from, the next port after it"
- + " will be used to transmit the audio RTCP from."
- + " Respectively, the subsequent ports will be used to"
- + " transmit the video RTP and RTCP from."
+ "The port which is the source of the transmission i.e. from"
+ + " which the media is to be transmitted. The specified"
+ + " value will be used as the port to transmit the audio"
+ + " RTP from, the next port after it will be used to"
+ + " transmit the audio RTCP from. Respectively, the"
+ + " subsequent ports will be used to transmit the video RTP"
+ + " and RTCP from."
},
{
REMOTE_HOST_ARG_NAME,
@@ -307,13 +307,12 @@ private void stop()
},
{
REMOTE_PORT_BASE_ARG_NAME,
- "The port which is the target of the transmission"
- + " i.e. to which the media is to be transmitted."
- + " The specified value will be used as the port to"
- + " transmit the audio RTP to, the next port after it"
- + " will be used to transmit the audio RTCP to."
- + " Respectively, the subsequent ports will be used to"
- + " transmit the video RTP and RTCP to."
+ "The port which is the target of the transmission i.e. to which"
+ + " the media is to be transmitted. The specified value"
+ + " will be used as the port to transmit the audio RTP to"
+ + " the next port after it will be used to transmit the"
+ + " audio RTCP to. Respectively, the subsequent ports will"
+ + " be used to transmit the video RTP and RTCP to."
}
};
@@ -321,7 +320,7 @@ public static void main(String[] args)
throws Exception
{
// We need two parameters to do the transmission. For example,
- // java org.jitsi.examples.AVTransmit2 --remote-host=127.0.0.1 --remote-port-base=10000
+ // ant run-example -Drun.example.name=AVTransmit2 -Drun.example.arg.line="--remote-host=127.0.0.1 --remote-port-base=10000"
if (args.length < 2)
{
prUsage();
--
GitLab