Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Knowledge Space WP Plugin
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
alg
Knowledge Space WP Plugin
Commits
34b16aaf
Commit
34b16aaf
authored
2 years ago
by
Maximilian Giller
Browse files
Options
Downloads
Patches
Plain Diff
Simplified reference structure a little
parent
6015e04f
No related branches found
No related tags found
No related merge requests found
Pipeline
#57091
failed
2 years ago
Stage: test
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/editor/components/referenceentry.tsx
+5
-18
5 additions, 18 deletions
src/editor/components/referenceentry.tsx
src/editor/components/referenceseditor.tsx
+11
-25
11 additions, 25 deletions
src/editor/components/referenceseditor.tsx
with
16 additions
and
43 deletions
src/editor/components/referenceentry.tsx
+
5
−
18
View file @
34b16aaf
import
React
,
{
useState
}
from
"
react
"
;
import
React
from
"
react
"
;
import
{
DescriptiveReference
}
from
"
../../common/graph/node
"
;
import
"
./nodetypeentry.css
"
;
type
ReferenceEntryProps
=
{
reference
:
DescriptiveReference
;
onReferenceDelete
:
(
url
:
string
)
=>
void
;
onReferenceChange
:
(
originalUrl
:
string
,
reference
:
DescriptiveReference
)
=>
void
;
onReferenceDelete
:
()
=>
void
;
onReferenceChange
:
(
reference
:
DescriptiveReference
)
=>
void
;
};
function
ReferenceEntry
({
...
...
@@ -16,23 +13,15 @@ function ReferenceEntry({
onReferenceDelete
,
onReferenceChange
,
}:
ReferenceEntryProps
)
{
const
[
editedReference
,
setEditedReference
]
=
useState
<
DescriptiveReference
>
(
reference
);
const
originalUrl
=
reference
.
url
;
const
onPropChange
=
(
prop
:
keyof
DescriptiveReference
,
newValue
:
string
)
=>
{
reference
[
prop
]
=
newValue
;
setEditedReference
(
reference
);
};
return
(
<
div
className
=
"reference"
onBlur
=
{
()
=>
onReferenceChange
(
originalUrl
,
editedReference
)
}
>
<
div
className
=
"reference"
onBlur
=
{
()
=>
onReferenceChange
(
reference
)
}
>
<
label
htmlFor
=
"reference-url"
>
Url
</
label
>
<
br
/>
<
input
...
...
@@ -52,9 +41,7 @@ function ReferenceEntry({
}
/>
<
br
/>
<
button
onClick
=
{
()
=>
onReferenceDelete
(
originalUrl
)
}
>
Delete
</
button
>
<
button
onClick
=
{
onReferenceDelete
}
>
Delete
</
button
>
</
div
>
);
}
...
...
This diff is collapsed.
Click to expand it.
src/editor/components/referenceseditor.tsx
+
11
−
25
View file @
34b16aaf
...
...
@@ -12,31 +12,15 @@ function ReferencesEditor({
references
,
onReferencesChange
,
}:
ReferencesEditorProps
)
{
const
isUrlUnique
=
(
url
:
string
):
boolean
=>
!
references
.
some
((
ref
:
DescriptiveReference
)
=>
ref
.
url
==
url
);
const
handleReferenceDelete
=
(
url
:
string
)
=>
{
references
=
references
.
filter
(
(
ref
:
DescriptiveReference
)
=>
ref
.
url
!=
url
);
const
handleReferenceDelete
=
(
index
:
number
)
=>
{
references
=
references
.
filter
((
ref
,
i
:
number
)
=>
i
!==
index
);
onReferencesChange
(
references
);
};
const
handleReferenceChange
=
(
url
:
string
,
reference
:
DescriptiveReference
reference
:
DescriptiveReference
,
index
:
number
)
=>
{
// Make sure url stays unique
if
(
isUrlUnique
(
reference
.
url
))
{
console
.
log
(
"
URL of changed reference is not unique anymore for current node. Cannot save changes on reference.
"
);
return
;
}
const
index
:
number
=
references
.
findIndex
(
(
ref
:
DescriptiveReference
)
=>
ref
.
url
==
url
);
references
[
index
]
=
reference
;
onReferencesChange
(
references
);
};
...
...
@@ -58,16 +42,18 @@ function ReferencesEditor({
<
ReferenceEntry
key
=
{
index
}
reference
=
{
reference
}
onReferenceChange
=
{
handleReferenceChange
}
onReferenceDelete
=
{
handleReferenceDelete
}
onReferenceChange
=
{
(
ref
)
=>
handleReferenceChange
(
ref
,
index
)
}
onReferenceDelete
=
{
()
=>
handleReferenceDelete
(
index
)
}
/>
);
}
)
}
<
br
/>
<
button
onClick
=
{
addReference
}
disabled
=
{
!
isUrlUnique
(
""
)
}
>
Add reference
</
button
>
<
button
onClick
=
{
addReference
}
>
Add reference
</
button
>
</
div
>
);
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment