Proper and custom equals method for nodes, links and nodetypes

src/editor/js/structures/graph/graph.ts

@@ -190,7 +190,7 @@ export class Graph extends ManagedData {
             return true; // Doesn't even exist in graph to begin with.
         }
 
-        this.data.nodes = this.data.nodes.filter((n: Node) => n.id !== node.id);
+        this.data.nodes = this.data.nodes.filter((n: Node) => !n.equals(node));
 
         try {
             // No save points should be created when deleting the links
@@ -263,11 +263,7 @@ export class Graph extends ManagedData {
             return true; // Doesn't even exist in graph to begin with.
         }
 
-        // TODO: Filter links by link id
-        this.data.links = this.data.links.filter(
-            (l: Link) =>
-                l.sourceId !== link.sourceId || l.targetId !== link.targetId
-        );
+        this.data.links = this.data.links.filter((l: Link) => !l.equals(link));
 
         this.triggerOnChange();
         // TODO: Use toString implementation of link
@@ -316,9 +312,8 @@ export class Graph extends ManagedData {
 
         // TODO: Remove, when types are directly parsed and not just implicit
         data.nodes.forEach((node) => {
-            const sharedType: NodeType = data.types.find(
-                // TODO: Use id instead, but not defined at the moment
-                (type) => type.name === node.type.name
+            const sharedType: NodeType = data.types.find((type) =>
+                type.equals(node.type)
             );
 
             if (sharedType !== undefined) {

src/editor/js/structures/graph/graphelement.ts

@@ -48,4 +48,16 @@ export class GraphElement extends SerializableItem {
             'Function "getCleanInstance()" has not been implemented.'
         );
     }
+
+    /**
+     * Compares to objects. Can be a custom implementation.
+     * @returns True, if given object is identical.
+     */
+    public equals(other: GraphElement): boolean {
+        return (
+            other.node == this.node &&
+            other.link == this.link &&
+            other.id == this.id
+        );
+    }
 }

src/editor/js/structures/graph/link.ts

@@ -128,4 +128,16 @@ export class Link extends GraphElement {
 
         return source.toString() + " -> " + target.toString();
     }
+
+    public equals(other: GraphElement): boolean {
+        if (!other.link || other.node) {
+            return false;
+        }
+
+        const link = other as Link;
+
+        return (
+            link.sourceId === this.sourceId && link.targetId === this.targetId
+        );
+    }
 }

src/editor/js/structures/graph/nodetype.ts

@@ -43,4 +43,14 @@ export class NodeType extends GraphElement {
     public toString(): string {
         return this.name;
     }
+
+    public equals(other: GraphElement): boolean {
+        if (other.link || other.node) {
+            return false;
+        }
+
+        const type = other as NodeType;
+
+        return type.name === this.name;
+    }
 }