embUnit: simplify `strcmp()` implementation

The logic of `stdimpl_strcmp()` was needlessly complicated and not
understood by scan-build. This change fixes the warning and makes the
code more readable.

Found via scan-build.