Skip to content
Snippets Groups Projects
Unverified Commit 3423008a authored by danpetry's avatar danpetry Committed by GitHub
Browse files

Merge pull request #9445 from bergzand/pr/maintaining/split_pr

doc: Add atomicity to review fundamentals
parents 904c5830 122650c1
No related branches found
No related tags found
No related merge requests found
...@@ -34,17 +34,19 @@ the overall validity of the PR. ...@@ -34,17 +34,19 @@ the overall validity of the PR.
Is the problem that the PR intends to solve clearly stated? Is the problem that the PR intends to solve clearly stated?
2. Is the solution presented in the PR as simple as possible to satisfy the 2. Is the solution presented in the PR as simple as possible to satisfy the
requirements, but no simpler? requirements, but no simpler?
3. Is the solution well designed on a high level? 3. Is the PR functionally atomic? Does it address a single issue or should
4. Do the concepts used by the PR make sense? it be split into multiple individual PRs?
5. Does the PR break with existing concepts? 4. Is the solution well designed on a high level?
6. Is the structure of the PR itself valid? 5. Do the concepts used by the PR make sense?
7. Are there clear and adequate instructions on how to test the PR? \ 6. Does the PR break with existing concepts?
7. Is the structure of the PR itself valid?
8. Are there clear and adequate instructions on how to test the PR? \
This may or may not include implemented tests as part of the PR. This may or may not include implemented tests as part of the PR.
8. Does the code compile and run? 9. Does the code compile and run?
9. Does this PR respect the rights of previous authors, either through 10. Does this PR respect the rights of previous authors, either through
retaining their commits or by retaining their copyrights in the boilerplate retaining their commits or by retaining their copyrights in the boilerplate
headers? headers?
10. Is the PR a duplicate of another PR? 11. Is the PR a duplicate of another PR?
### 2. - Review the design of the code ### 2. - Review the design of the code
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment