Skip to content
Snippets Groups Projects
Unverified Commit 3b9f34f2 authored by Koen Zandberg's avatar Koen Zandberg Committed by GitHub
Browse files

Merge pull request #9480 from danpetry/allow_time_to_ack 

Docs: add "allow time to ACK before dismissing review" to maintainer guidelines
parents 499d6b4e fb22cf89
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
Showing
with 5 additions and 0 deletions
MAINTAINING.md
+ 5
− 0
View file @ 3b9f34f2
...@@ -128,6 +128,11 @@ This could include: ...@@ -128,6 +128,11 @@ This could include:
review review
- Usage of GitHub functionality, for example "Reviewers" and "Assignees" lists - Usage of GitHub functionality, for example "Reviewers" and "Assignees" lists
#### Github etiquette
- If there are multiple maintainers reviewing a PR, always give the other
maintainers reasonable time to ACK before dismissing their review.
[list of maintainers]: https://github.com/RIOT-OS/RIOT/wiki/Maintainers [list of maintainers]: https://github.com/RIOT-OS/RIOT/wiki/Maintainers
[Best Practices]: https://github.com/RIOT-OS/RIOT/wiki/Best-Practice-for-RIOT-Programming [Best Practices]: https://github.com/RIOT-OS/RIOT/wiki/Best-Practice-for-RIOT-Programming
[Comparing build sizes]: https://github.com/RIOT-OS/RIOT/wiki/Comparing-build-sizes [Comparing build sizes]: https://github.com/RIOT-OS/RIOT/wiki/Comparing-build-sizes
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment