Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
R
RIOT
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
cm-projects
RIOT
Commits
4b11509b
Unverified
Commit
4b11509b
authored
6 years ago
by
Alexandre Abadie
Committed by
GitHub
6 years ago
Browse files
Options
Downloads
Plain Diff
Merge pull request #10669 from OTAkeys/pr/sx127x_irq
drivers/sx127x: remove irq_disable/irq_restore around spi transfers
parents
b6b4fed2
6b82b849
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
drivers/sx127x/sx127x_internal.c
+0
-12
0 additions, 12 deletions
drivers/sx127x/sx127x_internal.c
with
0 additions
and
12 deletions
drivers/sx127x/sx127x_internal.c
+
0
−
12
View file @
4b11509b
...
@@ -25,8 +25,6 @@
...
@@ -25,8 +25,6 @@
#include
<stdbool.h>
#include
<stdbool.h>
#include
<inttypes.h>
#include
<inttypes.h>
#include
"irq.h"
#include
"net/lora.h"
#include
"net/lora.h"
#include
"sx127x.h"
#include
"sx127x.h"
...
@@ -83,26 +81,18 @@ uint8_t sx127x_reg_read(const sx127x_t *dev, uint8_t addr)
...
@@ -83,26 +81,18 @@ uint8_t sx127x_reg_read(const sx127x_t *dev, uint8_t addr)
void
sx127x_reg_write_burst
(
const
sx127x_t
*
dev
,
uint8_t
addr
,
uint8_t
*
buffer
,
void
sx127x_reg_write_burst
(
const
sx127x_t
*
dev
,
uint8_t
addr
,
uint8_t
*
buffer
,
uint8_t
size
)
uint8_t
size
)
{
{
unsigned
int
cpsr
;
spi_acquire
(
dev
->
params
.
spi
,
SPI_CS_UNDEF
,
SX127X_SPI_MODE
,
SX127X_SPI_SPEED
);
spi_acquire
(
dev
->
params
.
spi
,
SPI_CS_UNDEF
,
SX127X_SPI_MODE
,
SX127X_SPI_SPEED
);
cpsr
=
irq_disable
();
gpio_clear
(
dev
->
params
.
nss_pin
);
gpio_clear
(
dev
->
params
.
nss_pin
);
spi_transfer_regs
(
dev
->
params
.
spi
,
SPI_CS_UNDEF
,
addr
|
0x80
,
(
char
*
)
buffer
,
NULL
,
size
);
spi_transfer_regs
(
dev
->
params
.
spi
,
SPI_CS_UNDEF
,
addr
|
0x80
,
(
char
*
)
buffer
,
NULL
,
size
);
gpio_set
(
dev
->
params
.
nss_pin
);
gpio_set
(
dev
->
params
.
nss_pin
);
irq_restore
(
cpsr
);
spi_release
(
dev
->
params
.
spi
);
spi_release
(
dev
->
params
.
spi
);
}
}
void
sx127x_reg_read_burst
(
const
sx127x_t
*
dev
,
uint8_t
addr
,
uint8_t
*
buffer
,
void
sx127x_reg_read_burst
(
const
sx127x_t
*
dev
,
uint8_t
addr
,
uint8_t
*
buffer
,
uint8_t
size
)
uint8_t
size
)
{
{
unsigned
int
cpsr
;
cpsr
=
irq_disable
();
spi_acquire
(
dev
->
params
.
spi
,
SPI_CS_UNDEF
,
SX127X_SPI_MODE
,
SX127X_SPI_SPEED
);
spi_acquire
(
dev
->
params
.
spi
,
SPI_CS_UNDEF
,
SX127X_SPI_MODE
,
SX127X_SPI_SPEED
);
gpio_clear
(
dev
->
params
.
nss_pin
);
gpio_clear
(
dev
->
params
.
nss_pin
);
...
@@ -110,8 +100,6 @@ void sx127x_reg_read_burst(const sx127x_t *dev, uint8_t addr, uint8_t *buffer,
...
@@ -110,8 +100,6 @@ void sx127x_reg_read_burst(const sx127x_t *dev, uint8_t addr, uint8_t *buffer,
gpio_set
(
dev
->
params
.
nss_pin
);
gpio_set
(
dev
->
params
.
nss_pin
);
spi_release
(
dev
->
params
.
spi
);
spi_release
(
dev
->
params
.
spi
);
irq_restore
(
cpsr
);
}
}
void
sx127x_write_fifo
(
const
sx127x_t
*
dev
,
uint8_t
*
buffer
,
uint8_t
size
)
void
sx127x_write_fifo
(
const
sx127x_t
*
dev
,
uint8_t
*
buffer
,
uint8_t
size
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment