Skip to content
Snippets Groups Projects
  1. Aug 18, 2017
    • Dan Burkert's avatar
      small fixups in bytes.rs (#145) · 03d501b1
      Dan Burkert authored
      * Inner: make uninitialized construction explicit
      * Remove Inner2
      * Remove unnecessary transmutes
      * Use AtomicPtr::get_mut where possible
      * Some minor tweaks
      03d501b1
  2. Aug 17, 2017
  3. Aug 12, 2017
  4. Aug 06, 2017
  5. Jul 02, 2017
  6. Jul 01, 2017
  7. Jun 27, 2017
  8. Jun 26, 2017
  9. Jun 15, 2017
  10. May 26, 2017
  11. May 24, 2017
  12. May 22, 2017
  13. May 15, 2017
    • Stepan Koltsov's avatar
      BytesMut::reserve should not overallocate (#117) · 7110d57b
      Stepan Koltsov authored
      Round up to power of 2 is not necessary, because `reserve` already
      doubles previous capacity in
      
      ```
      	new_cap = cmp::max(
      		cmp::max(v.capacity() << 1, new_cap),
      		original_capacity);
      ```
      
      which makes `reserve` calls constant in average. Avoiding rounding
      up prevents `reserve` from wasting space when caller knows exactly
      what space they need.
      
      Patch adds three tests which would fail before this test. The most
      important is this:
      
      ```
      #[test]
      fn reserve_in_arc_unique_does_not_overallocate() {
          let mut bytes = BytesMut::with_capacity(1000);
          bytes.take();
      
          // now bytes is Arc and refcount == 1
      
          assert_eq!(1000, bytes.capacity());
          bytes.reserve(2001);
          assert_eq!(2001, bytes.capacity());
      }
      ```
      
      It asserts that when user requests more than double of current
      capacity, exactly the requested amount of memory is allocated and
      is not wasted to next power of two.
      7110d57b
    • Stepan Koltsov's avatar
      Bytes::extend_from_slice (#120) · 07db74b0
      Stepan Koltsov authored
      `extend_with_slice` is super-convenient operation on `Bytes`.
      
      While `put_u8` would be expensive on `Bytes`, `extend_from_slice`
      is OK, because it is batch, and it checks for kind only once.
      
      Patch also adds `impl Extend for Bytes`.
      
      cc #116
      07db74b0
  14. May 02, 2017
  15. May 01, 2017
  16. Apr 30, 2017
  17. Apr 26, 2017
  18. Apr 24, 2017
  19. Apr 14, 2017
  20. Apr 06, 2017
  21. Apr 05, 2017
  22. Mar 30, 2017
    • Carl Lerche's avatar
      Bytes: only the vec repr is not shared (#100) · 9aa24ebe
      Carl Lerche authored
      The shared debug_assert is to ensure that the internal Bytes
      representation is such that offset views are supported. The only
      representation that does not support offset views is vec.
      
      Fixes #97
      9aa24ebe
  23. Mar 28, 2017
    • Stepan Koltsov's avatar
    • Stepan Koltsov's avatar
      Handle corner cases of Bytes::split_{off,to} (#87) · b78bb3ba
      Stepan Koltsov authored
      Before this commit `Bytes::split_{off,to}` always created a shallow copy if `self` is arc or vec.
      
      However, in certain cases `split_off` or `split_to` is called with `len` or `0` parameter. E. g. if you are reading a frame from buffered stream, it is likely that buffer contains exactly the frame size bytes, so `split_to` will be called with `len` param.
      
      Although, `split_off` and `split_to` functions are `O(1)`, shallow copy have downsides:
      
      * shallow copy on vector does malloc and atomic cmpxchg
      * after shallow copy, following operations (e. g. `drop`) on both `bytes` objects require atomics
      * memory will be probably released to the system later
      * `try_mut` will fail
      * [into_vec](https://github.com/carllerche/bytes/issues/86) will copy
      b78bb3ba
  24. Mar 24, 2017
  25. Mar 21, 2017
    • Stepan Koltsov's avatar
      Reimplement fmt::Debug for Bytes and BytesMut (#84) · 613d4bd5
      Stepan Koltsov authored
      Standard `Debug` implementation for `[u8]` is comma separated list
      of numbers. Since large amount of byte strings are in fact ASCII
      strings or contain a lot of ASCII strings (e. g. HTTP), it is
      convenient to print strings as ASCII when possible.
      613d4bd5
  26. Mar 20, 2017
    • Carl Lerche's avatar
      Misc CI fixes (#89) · dc9c8e30
      Carl Lerche authored
      Limit the number of threads when using qemu to 1. Also, don't bother
      running the stress test as this will trigger qemu bugs. Finally, also
      make the stress test actually stress test.
      dc9c8e30
  27. Mar 19, 2017
Loading