Skip to content
Snippets Groups Projects
  • Nadav Har'El's avatar
    bf513903
    Strip tests, but keep "make check" working · bf513903
    Nadav Har'El authored
    
    This patch reverts commit 831b017e,
    which stopped stripping the tests in order to fix "make check", and
    instead just fixes the latter.
    
    The fix is trivial: "make check" finds the list of tests not from the
    image or the manifest, but from the list of files in build/release/tests.
    So all we need to do is to subtract from that list the list of *-stripped.so.
    
    As to the question *why* to strip the tests:
    
    In the past, several people raised the desire to include our tests on some
    production images (not just the "make image=tests" one). The rationale behind
    this is that if the image encounters unexpected problems on some cloud, we
    can run the included tests to see if something if it can find a problem.
    
    I'm not sure this is a compelling reason to include tests in every image,
    but let's at least not rule the option to include them on some image.
    
    The difference in size between the stripped and unstripped tests is huge:
    Currently, unstripped tests total 18 MB, while the stripped are just 2.2 MB.
    That's more than 8 times smaller! We can easily imagine that in the future
    we'll have more tests - perhaps many, many more tests, making this difference
    even more significant.
    
    Signed-off-by: default avatarNadav Har'El <nyh@cloudius-systems.com>
    Signed-off-by: default avatarPekka Enberg <penberg@cloudius-systems.com>
    bf513903
    History
    Strip tests, but keep "make check" working
    Nadav Har'El authored
    
    This patch reverts commit 831b017e,
    which stopped stripping the tests in order to fix "make check", and
    instead just fixes the latter.
    
    The fix is trivial: "make check" finds the list of tests not from the
    image or the manifest, but from the list of files in build/release/tests.
    So all we need to do is to subtract from that list the list of *-stripped.so.
    
    As to the question *why* to strip the tests:
    
    In the past, several people raised the desire to include our tests on some
    production images (not just the "make image=tests" one). The rationale behind
    this is that if the image encounters unexpected problems on some cloud, we
    can run the included tests to see if something if it can find a problem.
    
    I'm not sure this is a compelling reason to include tests in every image,
    but let's at least not rule the option to include them on some image.
    
    The difference in size between the stripped and unstripped tests is huge:
    Currently, unstripped tests total 18 MB, while the stripped are just 2.2 MB.
    That's more than 8 times smaller! We can easily imagine that in the future
    we'll have more tests - perhaps many, many more tests, making this difference
    even more significant.
    
    Signed-off-by: default avatarNadav Har'El <nyh@cloudius-systems.com>
    Signed-off-by: default avatarPekka Enberg <penberg@cloudius-systems.com>