file: drop file_makebad()

The only caller, soo_close() can only be called from a context where
no file references remain, so no further file API calls can be made.

Remove it.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

bsd/sys/kern/sys_socket.c

@@ -274,7 +274,6 @@ soo_close(struct file *fp)
     struct socket *so;
 
     so = file_data(fp);
-    file_makebad(fp);
 
     if (so)
         error = soclose(so);

fs/vfs/kern_descrip.cc

@@ -229,12 +229,6 @@ file::~file()
     }
 }
 
-void file_makebad(struct file *fp)
-{
-    fp->f_ops = &badfileops;
-    fp->f_data = NULL;
-}
-
 dentry* file_dentry(file* fp)
 {
     return fp->f_dentry;

include/osv/file.h

@@ -140,7 +140,6 @@ filetype_t file_type(struct file *fp);
 void* file_data(struct file *fp);
 void file_setdata(struct file *fp, void *data);
 int file_flags(struct file *fp);
-void file_makebad(struct file *fp);
 struct dentry* file_dentry(struct file *fp);
 off_t file_offset(struct file *fp);
 void file_setoffset(struct file *fp, off_t off);