-
- Downloads
VFS: cleanup readdir() and friends
Our readdir_r() and friends were implemented in libc/dir.cc, calling a function "ll_readdir()" from fs/vfs/main.cc. The name of this function was confusing ("ll_" seemed to imply lock-less, which it isn't), and the way it was "extern"ed was ugly, as a comment even admitted. Moreover, when we want to implement more missing functions like rewinddir() (see issue #77), we need to write more of these silly "ll_*" wrapper functions. Instead, let's just move the few dir.cc functions into main.cc. The latter already defines most of our filesystem system calls, so feels the right place anyway. This change allows us to get rid of the silly ll_readdir() layer, and makes implementing rewinddir() trivial (see next patch). Signed-off-by:Nadav Har'El <nyh@cloudius-systems.com> Signed-off-by:
Pekka Enberg <penberg@cloudius-systems.com>
Loading
Please register or sign in to comment