Skip to content
Snippets Groups Projects
Commit a02a6bc5 authored by Nadav Har'El's avatar Nadav Har'El Committed by Pekka Enberg
Browse files

VFS: cleanup readdir() and friends


Our readdir_r() and friends were implemented in libc/dir.cc, calling
a function "ll_readdir()" from fs/vfs/main.cc. The name of this function
was confusing ("ll_" seemed to imply lock-less, which it isn't), and the way
it was "extern"ed was ugly, as a comment even admitted.

Moreover, when we want to implement more missing functions like rewinddir()
(see issue #77), we need to write more of these silly "ll_*" wrapper functions.

Instead, let's just move the few dir.cc functions into main.cc. The latter
already defines most of our filesystem system calls, so feels the right
place anyway. This change allows us to get rid of the silly ll_readdir()
layer, and makes implementing rewinddir() trivial (see next patch).

Signed-off-by: default avatarNadav Har'El <nyh@cloudius-systems.com>
Signed-off-by: default avatarPekka Enberg <penberg@cloudius-systems.com>
parent caf9cbe0
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment