The call to namei("/dir/file/") currently fails with ENOENT when
"/dir/file" exists. A more standard way is to return ENOTDIR
instead. This way calls to stat, open, rename, etc. will be in
line with the POSIX spec.

It is also useful to rename() implementation which needs to
differentiate behaviour between the case in which target does not
exist and the case in which it does but the path has trailing slash
and the last component is not a directory.

In addition to that the check was performed in an inconsistent matter
- only when dentry lookup failed. This change makes the check
performed always.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

When converting a source file from .c to .cc, make will complain that the
old source file was missing.  This is annoying, especially when bisecting
or compile-testing a patch set.

Fix by removing the source file dependency.  Since the dependency is alread
specified explicitly by the makefile, no information is lost.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Add 'werror' option to Makefile that can be used to disable the -Werror
GCC option temporarily as follows:

  make werror=0

This is useful when fixing up build breakage caused by addition of new
default compiler warnings.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Some distributions have enabled gcc -Wformat-security by default.
This causes the build to raise format warnings even though -Wformat=0
is used.

Setting no-format-security for build consistency between distros.

Signed-off-by: Or Cohen <orc@fewbytes.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

For example, assuming the following file exists:

  /tmp/dir/x

..the following was sondiered absent:

  /tmp/dir/

..this was considered present:

  /tmp/dir

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Needed to link with boost_filesystem.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

This patch adds version numbering to the loader. We use "git tag" for
generating an unique version number with a little bit of shell script
magic to make sure version number is always up-to-date.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

strlcpy() expects buffer length not string length.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Not supported by older qemus.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Drop sudo and global /zfs temporary directory.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

This drops the superuser requirement from the build process, and reduces
the build prerequisite list.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

This allows using the boost libraries in shared objects.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Dump registers on general protection fault for debugging purposes.  Even
if you have gdb available, getting to the exception frame is not always
possible after OSv has crashed.

Example output looks as follows:

registers:
RIP: 0x0000100000b7e913  RFL: 0x0000000000010202  CS:  0x0000000000000008  SS:  0x0000000000000010
RAX: 0xffffc000418ed278  RBX: 0xffffc00041b2c050  RCX: 0x0000000000000004  RDX: 0x0000000000000000
RSI: 0x0000000000000001  RDI: 0x43e0000000000000  RBP: 0x0000200008548d10  R8:  0xffffc000426e3010
R9:  0x0000000000000004  R10: 0x43e0000000000000  R11: 0xffffc00041b2c050  R12: 0xffffc000418ed1e8
R13: 0x0000000000000004  R14: 0x43e0000000000000  R15: 0xffffc00041b2c050  RSP: 0x0000200008548aa0
general protection fault

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Create a file system on top of the pool.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

For the moment, it only creates a zpool, not a filesystem.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Related changes previously made in java/build.xml
were reverted and moved to java/runjava/build.xml

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Building with ant requires no changes in the build scripts
when new classes are added. It is a standrd tool to build
java programs.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

We don't want it in /usr, because it won't have been created yet.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

This also requires fixing paths to mgmt jars in build.mk
and usr.manifest as the version scheme has changed.

git log --format=short 7a4db4e759b..54f4810a7:

  commit 54f4810a76fabf955aeea34baefa336abf8b8467
  Author: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

      Revert "supporting artifactory publish"

  commit 4abf771d146d6cde66f330e6b6ab6ececffb4cdd
  Author: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

      mgmt/web: ditch jline-2.7 pulled by jruby-core

  commit 3863a3b58b661cd751314966cccb0f6c9835ed4a
  Author: Nadav Har'El <nyh@cloudius-systems.com>

      Moved RunJava to io.osv namespace

  commit be0717595f45d647062e7a41cc8dd38393c96547
  Author: Ronen Narkis <narkisr@gmail.com>

      supporting testing (jruby rake test does not work no matter what)

  commit 46e74f6bb886a0c62b06f08559fe2e44efdb8900
  Author: Ronen Narkis <narkisr@gmail.com>

      ignoring build

  commit 95ff3b70bae877d5d8cf0144853d1a201a0be333
  Author: Ronen Narkis <narkisr@gmail.com>

      verfying json existence and giving meaning full error

  commit 8b60c4a40aa4bcb7ce08bba600fd9cd6d63e1073
  Author: Ronen Narkis <narkisr@gmail.com>

      moving to three digit versioning in order to have a finer grained control on rel

  commit ffa7646388cec8d5b138ff4fc28a985c6344824c
  Author: Ronen Narkis <narkisr@gmail.com>

      supporting artifactory publish

  commit 8855112e2c867b4f855ed28ad9d9982c26bc56a3
  Author: Ronen Narkis <narkisr@gmail.com>

      clearing unused repo

  commit 3be79eb18b2be7bf1f28aaebd9905ac77945e4e4
  Author: Or Cohen <orc@fewbytes.com>

      Migrated ifconfig from previous JS console

  commit 287b014cf709e9c46692c59f87b70ebf056114b5
  Author: Or Cohen <orc@fewbytes.com>

      Migrated run command from previous CLI

  commit 0ffe064d30c1a812d7e853ee568ce45bfc16ed42
  Author: Or Cohen <orc@fewbytes.com>

      Added daemonizeIfNeeded helper method for commands

  commit 36951a86493c954a2e939648b5060260fac5b539
  Author: Or Cohen <orc@fewbytes.com>

      Moved ELFLoader from cloudius.cli to cloudius.util

We want to tweak the include order for solaris (solaris -> bsd -> osv)
compared to osv (osv -> bsd) or bsd (bsd -> osv), so put these includes
in their own variable which can be nulled out.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

We have _KERNEL defines scattered throughout the code, which makes
understanding it difficult.

Define it just once, and adjust the source to build.

We define it in an overridable variable, so that non-kernel imported code
can undo it.

We use the RunJava Java class to run Java applications (both java.so
and the "java" CLI command use it). We used to have RunJava.class
uncompressed, in the /java directory, but this caused two problems:

1. Or noticed that having a directory (/java) on the classpath causes
   thousands of stat() calls when Java tries to look for all classes
   in this directory. With a jar, its contents are read only once.

2. The "java" CLI command (java.groovy) didn't work because apparently
   Groovy cannot deal with classes being in the top-level package.

   So this patch moves RunJava into the io.osv package, and put it into a jar
   /java/runjava.jar.

   Note that java.groovy is changed in a separate patch (because it's in
   a different sub-repository....)

Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com>

This patch uses boost::asio::ip::address* to cleanup the core dhcp code.

Signed-off-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Removing loader.img causes a null build to rebuild it and usr.img.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

This patch adds support for the Linux kill(2) function.
The next patch will add alarm(2) support, which uses kill(2).

To be honest, we sort-of implement kill(). This implementation is
compatible with the API, but the semantics are somewhat different:
While in Linux kill() causes the signal handler to run on one of the
existing threads, in this implementation, the signal handler is run in a
*new* thread.

Implementing the exact Linux semantics in OSv would require tracking when
OSv runs kernel code (i.e., code in the main executable, not a shared
object) so we can delay running the signal handler until returning to the
user code. Moreover, we'll need to be able to interrupt sleeping kernel
code. This is complicated and adds overhead even if signals aren't used
(and they aren't used in most modern code).

I expect that this code will be "good enough" in many use cases.
This code will *not* be good in enough in programs that expect one of the
following:

1. A program that by using Posix Thread's "signal masks" tried to ensure
   that the signal is delivered to one specific thread, and not to an
   arbitrary thread.

2. A program that used kill() or alarm() not intending to run a signal
   handler, but rather intending to interrupt a sleeping system call
   like sleep() or read(). Our kill() does not interrupt sleeping OSv
   function calls, which will continue to sleep on the thread they run
   on.

The support in this patch (and see next patch, for alarm()) is good
enough for netperf's use of alarm().

P.S. kill() can be used only to send a signal to the current process, the
only process we have in OSv (you can also use pid=0 and pid=-1 to achieve
the same results).

This patch also adds a test for kill() and alarm(). The alarm() test
will fail until the next patch :-)

Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com>

Add a basic test case for filesystem hard link support. You can run it as
follows:

  ./scripts/run.py -e "tests/tst-fs-link.so"

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Add a trivial sleep() test, which sleep()s for 2 seconds, and verifies
that this finishes and has slept for roughly 2 seconds.

I used this for debugging issue #26 - the attempts there ruined timers,
and in particular this trivial test hangs, as sleep() never returns.

(A note to our future automatic testing implementor: We need to allow
for the possibility that a test doesn't cleanly fail, but rather hangs,
and consider this a failure too).

Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com>

This regression test trigger issue #8
"Make Java InetAddress.getHostName() work" by exercising the DNS
resolver on localhost and a dns root server.

The test takes care of specifying NI_NOFQDN to resolve only the
hostname part of localhost ip.

It appears that the DNS ip is not communicated to the libc by
core/dhcp.cci: /etc/resolv.conf is not filled.

Test contributed while waiting for an fix idea to implement.

Signed-off-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>