The main purpose is to exercise the new parameter checks added to
mmap to handle wrong combination of parameters.
Let's intentionally force errors and catch them with the respective errno codes.

Signed-off-by: Raphael S. Carvalho <raphaelsc@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

(flags & MAP_ANONYMOUS) must be instead of (fd == -1) to determine
the mapping type as the latter one is a valid argument to file mappings.
Tests related to files were added into mmap_validate_file.

Signed-off-by: Raphael S. Carvalho <raphaelsc@cloudius-systems.com>
[ penberg: cleanups ]
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Rename mmap_validate_flags to mmap_validate as it's not only related to
flags now.  Add new tests to check bad paramater values.

Signed-off-by: Raphael S. Carvalho <raphaelsc@cloudius-systems.com>
[ penberg: cleanups ]
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

storage/runtime arguments for tracepoint can be inferred from
assign() function signature instead of specified explicitly
by storage_args/runtime_args. This makes boilerplate code smaller.

Signed-off-by: Gleb Natapov <gleb@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Make sure ZFS intention log is flushed to disk by unmounting rootfs at
poweroff.

Fixes #108.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Make sure the new root vnode is not evicted in vflush() and that we
don't keep reference to the old root dentry in ->m_covered.

Fixes negative dentry count when pivoted root is unmounted.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Add sys_umount2() and implement support for MNT_FORCE that will be used
to force rootfs unmount at poweroff.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

This is a temporary fix. I really feel we need failure detection based
on exit code.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Add error scanning to test.py based on known patterns in stdout and
stderr and stop test execution on error to make broken test cases stand
out.

Example output looks as follows:

  PASS: link returns ENOENT if source path does not exists
  PASS: create a file
  PASS: close the file
  PASS: create a hard link
  PASS: link returns EEXIST if destination path exists
  PASS: read content from another link
  PASS: stat the file
  PASS: hard link count is increased
  PASS: stat the hard link
  PASS: stat device IDs match
  PASS: stat inode numbers match
  PASS: remove the hard link
  PASS: stat the file
  FAIL: hard link count is decreased
  PASS: remove the file
  SUMMARY: 15 tests, 1 failures
  Powering off.

  Test '/tests/tst-fs-link.so' FAILED
  make: *** [check] Error 1

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Subsumed by make_file().

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Makes it easy to avoid losing them.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Combines falloc_noinstall() and finit(), which are always used together.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

falloc() is inherently racy in that it makes visible (via an fd) a file
structure that is not initialized.

Remove its uses and falloc() itself.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

falloc() is inherently racy in that it installs an uninitialized file
descriptor in a user accessible fd.  It is also hard to use correctly when
an error occurs.  Luckily, we don't use it anywhere, so we can just remove it.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

falloc() is racy since it installs an uninitialized file in an accessible fd.
Use falloc_noinstall() and fdalloc() instead; also fixes fd leaks on error.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

falloc() is racy since it installs an uninitialized file in an accessible fd.
Use falloc_noinstall() and fdalloc() instead; also fixes an fd leak on error.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

falloc() is racy since it installs an uninitialized file in an accessible fd.
Convert sys_close() to C++ and avoid the race; also fixes an fd leak in case
of an error.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Copying filerefs is expensive since the reference count is incremented,
avoid it.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Currently, we only check if neither MAP_PRIVATE nor MAP_SHARED were
passed to mmap, however, if it was called with both flags, then EINVAL
should be returned.

Signed-off-by: Raphael S. Carvalho <raphaelsc@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Asias He <asias@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

* Admin UI links fixed
* CRaSH 1.3.0-beta11

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Use ISIG flag for our stty call from jline, in order to translate INT to ^C.
ISIG was added in "Add interrupt and quit keys" (d7292625).

This is related to issue #53.

Reviewed-by: Tomasz Grabiec <tgrabiec@gmail.com>
Signed-off-by: Or Cohen <orc@fewbytes.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Asias He <asias@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Currently sys_open() receives an uninitialized file structure from its
callers, which is awkward as the callers must handle opening a file in
two steps.  It also doesn't fit well with C++'s notion of an object being
always fully initialized and valid.

Fix by making sys_open() allocate and return the file structure.  This also
fixes a window in open() where an fd would point to an uninitialized file
(between fdalloc() and sys_open()).

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Without it secure random generator doesn't use /dev/random
source, which leads to slow startup of tomcat.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Add a simple test case for "/dev/random" which just reads from the file
and prints out the random bytes.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

This adds the virtio-rng driver to OSv.  The implementation is simple:

  - Start a thread that keeps 64 byte of entropy cached in internal
    buffer.  Entropy is gathered from the host with virtio-rng.

  - Create device nodes for "/dev/random" and "/dev/urandom" that both
    use the same virtio_rng_read() hook.

  - Use the entropy buffer for virtio_rng_read().  If we exhaust the
    buffer, wake up the thread and wait for more entropy to appear.

We eventually should move device node creation to separate
drivers/random.c that multiplexes between different hardware RNG
implementations.  However, as we only support virtio-rng, I'm leaving
that to whomever implements support for the next RNG.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Not all virtio devices support MSI.  Fix device initialization by not
writing to VIRTIO_MSI_QUEUE_VECTOR register if a PCI device does not
advertise MSI-X support.  This is needed to initialize virtio-rng
devices when running on KVM/QEMU.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Enable device_destroy() API for the virtio-rng driver.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Add license file (BSD license) for fastlog2() function used in the
new scheduler as a quick approximate logf().
From https://code.google.com/p/fastapprox/

.

Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Before this patch, OSv crashes or continuously reboots when given unknown
command line paramters, e.g.,

        scripts/run.py -c1 -e "--help --z a"

With this patch, it says, as expected that the "--z" option is not
recognized, and displays the list of known options:

    unrecognised option '--z'
    OSv options:
      --help                show help text
      --trace arg           tracepoints to enable
      --trace-backtrace     log backtraces in the tracepoint log
      --leak                start leak detector after boot
      --nomount             don't mount the file system
      --noshutdown          continue running after main() returns
      --env arg             set Unix-like environment variable (putenv())
      --cwd arg             set current working directory
    Aborted

The problem was that to parse the command line options, we used Boost,
which throws an exception when an unrecognized option is seen. We need
to catch this exception, and show a message accordingly.

But before this patch, C++ exceptions did not work correctly during this
stage of the boot process, because exceptions use elf::program(), and we
only set it up later. So this patch moves the setup of the elf::program()
object earlier in the boot, to the beginning of main_cont().

Now we'll be able to use C++ exceptions throughout main_cont(), not just
in command line parsing.

This patch also removes the unused "filesystem" paramter of
elf::program(), rather than move the initializion of this empty object
as well.

Fixes #103.

Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>