Skip to content
Snippets Groups Projects
  1. Mar 04, 2014
  2. Feb 12, 2014
  3. Feb 11, 2014
  4. Feb 07, 2014
  5. Feb 06, 2014
  6. Jan 27, 2014
  7. Jan 22, 2014
  8. Jan 21, 2014
  9. Jan 16, 2014
  10. Jan 15, 2014
  11. Jan 10, 2014
  12. Jan 02, 2014
  13. Dec 27, 2013
  14. Dec 20, 2013
  15. Dec 19, 2013
  16. Dec 18, 2013
  17. Dec 17, 2013
    • Nadav Har'El's avatar
      Fix assertion failure during many-cpu boot · 0b9fc40b
      Nadav Har'El authored
      
      While booting with many cpus (e.g., run.py -c 20, but I sometimes saw this
      with as few as 7), we crashed while trying to sleep with preemption disabled:
      
      Assertion failed: preemptable() (/home/nyh/osv/include/sched.hh: do_wait_until: 605)
      Aborted
      
      Turns out that since commit 223b2252 (half a year ago), main_cont()
      ran smp_launch() with preemption disabled. But smp_launch creates threads,
      and thread's constructor may sleep (e.g., on the thread_list_mutex), and
      we cannot do this with preemption disabled...
      
      So dropped the preempt_disable()/enable() from main_cont(). The reasoning for
      it as expressed in 223b2252 appears to be no longer relevant.
      
      Fixes #130.
      
      Signed-off-by: default avatarNadav Har'El <nyh@cloudius-systems.com>
      Signed-off-by: default avatarPekka Enberg <penberg@cloudius-systems.com>
      0b9fc40b
  18. Dec 11, 2013
  19. Dec 06, 2013
  20. Dec 05, 2013
Loading