Spotted by Clang:

../../include/sched.hh:278:12: error: class 'arch_cpu' was previously
declared as a struct
      [-Werror,-Wmismatched-tags]
    friend class arch_cpu;
           ^
../../arch/x64/arch-cpu.hh:39:8: note: previous use is here
struct arch_cpu {
       ^
../../include/sched.hh:278:12: note: did you mean struct here?
    friend class arch_cpu;
           ^~~~~
           struct

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Spotted by Clang:

../../include/sched.hh:278:12: error: class 'arch_cpu' was previously declared as a struct
      [-Werror,-Wmismatched-tags]
    friend class arch_cpu;
           ^
../../arch/x64/arch-cpu.hh:39:8: note: previous use is here
struct arch_cpu {
       ^
../../include/sched.hh:278:12: note: did you mean struct here?
    friend class arch_cpu;
           ^~~~~
           struct

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Spotted by Clang:

../../include/osv/trace.hh:58:1: error: 'assigner_type' defined as a struct template here but
      previously declared as a class template [-Werror,-Wmismatched-tags]
struct assigner_type<storage_args<s_args...>, runtime_args<r_args...>> {
^
../../include/osv/trace.hh:45:1: note: did you mean struct here?
class assigner_type;
^~~~~
struct

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Needed to link with boost_filesystem.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Spotted by GCC:

../../tests/tst-solaris-taskq.c: In function ‘tq_test_func’:
../../tests/tst-solaris-taskq.c:25:2: error: format ‘%s’ expects argument of type ‘char *’, but argument 3 has type ‘void *’ [-Werror=format=]
  kprintf("%s called for %s\n", __func__, arg);
  ^

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Or Cohen <orc@fewbytes.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

m_print() used special format specifiers from BSD's printf(9).

http://www.unix.com/man-page/freebsd/9/printf/



Instead of re-implementing these specifiers in different ways and
because this method is not being used anywhere, it was completely
removed.

Signed-off-by: Or Cohen <orc@fewbytes.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

ether_sprintf() used special format specifiers from BSD's printf(9).

http://www.unix.com/man-page/freebsd/9/printf/



Instead of re-implementing these specifiers in different ways and
because this method is not being used anywhere, it was completely
removed.

Signed-off-by: Or Cohen <orc@fewbytes.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Or Cohen <orc@fewbytes.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Currently, OSv release numbers would look like this:

  $ git describe --tags --long
  v0.02-0-gc40b86b

Stop using "--long" and let "git describe" do the right thing:

  $ git describe --tags
  v0.01-298-g42d11fb
  $ git tag v0.02
  $ git describe --tags
  v0.02

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Use the latest and greatest mgmt in preparation for v0.02.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

As noticed by Tomek in issue #64, unhandled C++ exceptions cause OSv to
silently hang, in an endless loop inside the unwinding code.

So this patch fixes the wrong CFI (DWARF Call Frame Information) which
caused the unwinder to loop. We just had a single line of assembly missing:
The topmost frame - the thread's main function - needs to undefine the
saved %rip to prevent going further back. If we don't do that, gdb will
end every "bt" output with a warning "Frame did not save its PC" (but hey,
nobody complained... ;-)), and the unwinding library, will, unfortunately,
go into an endless loop as seen in issue #64.

With this one-line patch, unhandled exceptions now work as expected -
they abort with a message like:

	terminate called after throwing an instance of 'int'
	Aborted

And attaching a debugger you can see exactly where the offending throw came
from (i.e., the stack does *not* unnecessarily unwind when there's nobody
waiting to catch the exception).

This works for uncaught exceptions anywhere - including inside main()
and from constructors when loading the object (before running main()).

"bt" in gdb also no longer ends each stack trace with an error message.
The last frame it shows is "thread_main()".

Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com>

We are switching to Amazon S3 for OSv pre-built image releases.

The script uses S3cmd:

  http://s3tools.org/s3cmd



which can be installed on Fedora with:

  yum install s3cmd python-magic

Please remember to configure your Amazon S3 credentials before running
the script:

  s3cmd --configure

To release a new version of OSv:

  git tag <version>

  ./scrips/release-s3

  git push --tags

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Use osv::poweroff() instead of abort() in exit() to make the VM stop
cleanly on JVM System.exit().

Needed by DaCapo.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

This patch adds version numbering to the loader. We use "git tag" for
generating an unique version number with a little bit of shell script
magic to make sure version number is always up-to-date.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

After commit 9bb55838, the name our jars
now contains the version number 1.0.0 instead of 1.0. The default command
line was changed accordingly (in build.mk), but we forgot to likewise
update the example in the README. This trivial patch fixes the example.

Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com>

The debug() call can deadlock because it's using boost format. Switch to
debug_ll().

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Needed to make dump_registers() safe to call from fault handler.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

The debug() format string is missing a newline. Fix that up.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

This is a workaround for linker error when compiling with -O0

  `.text._Z9safe_loadIcEbPKT_RS0_' referenced in section `.text.fixup'
  of core/mmu.o: defined in discarded section
  `.text._Z9safe_loadIcEbPKT_RS0_[_Z9safe_loadIcEbPKT_RS0_]' of
  core/mmu.o

The safe_load() template is used in both runtime.cc and core/mmu.cc
but the linker keeps it only in one section discarding the other.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

When building with -O0 we get:

 bsd/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.o: In
 function `zfs_ioc_destroy_snaps_nvl':
 (...)/bsd/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c:3265:
 undefined reference to `zvol_remove_minor'

Looks like the problem is that the missing symbol,
`zvol_remove_minor', referenced from zfs_ioctl.o is not in the zvol.o
because it's not defined, because it is inside '#ifdef NOTYET' block
(which is off). It works in the normal build because when compiled
with -O2 (and even with -O1), the reference to zvol_remove_minor in
zfs_ioctl.c is optimized away.

This patch puts the block using zvol_remove_minor also inside '#ifdef
NOTYET' to be consistent.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

This adds a script for releasing OSv QCOW2 images to Artifactory.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

FreeBSD networking code limits IP datagram size by IP_MAXPACKET
which is exactly 64K. This calculation doesn't take into account
Ethernet header length and may generate Ethernet packet longer than 64K.

Such a packet cannot be processed properly by some devices (Xen netback)
and being dropped.

This patch fixes this corner case for all supported IP protocols.

Signed-off-by: Dmitry Fleytman <dmitry@daynix.com>

This patch fixes part of TCP instability/low throughput problems on Xen.

On transmit networking stack passes to Xen netfront driver a list of mbufs
of up to PAGE_SIZE (4096) bytes each.
In case the list consists of more than MAX_TX_REQ_FRAGS (18) fragments
driver tries to defragment it with m_defrag().

m_defrag() in turn tries to build list of buffers of up to MCLBYTES
(2048) bytes each. This leads to even longer chain and packet being dropped.
As a result around 1% of TCP segments are lost and intensive TCP
retransmissions and slowdowns occur.

This patch makes m_defrag() use Jumbo packets zone for allocation, i.e.
PAGE_SIZE per mbuf.

This patch is pretty similar to what Glauber done on RX path before.

Signed-off-by: Dmitry Fleytman <dmitry@daynix.com>

Add a 'make check' target that runs whitelisted tests under OSv.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Like commit b17819df ("mmu: optimize searching for vmas") but for rest of
core/mmu.cc.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Make the adding file message less intimidating.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

We should pass the image path to run.py

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

This will be needed my mkzfs.py

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Start listening as soon as the guest is running. This makes host
mkzfs.py conneciton less racy and fixes OSv image creation problems I'm
seeing.

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

strlcpy() expects buffer length not string length.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

When the build/ directory is on tmpfs then 'cache=none' option makes
qemu fail with error:

    could not open disk image build/release/usr.img : Invalid argument

Using tmpfs for build/ makes a _huge_ difference in build time on some
setups.

This patch adds fallback to 'unsafe' mode when direct IO is not
supported.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Not supported by older qemus.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Not supported on osv, and reported to break the build on some systems.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Switch osv to built-in mkfs rather than zfs-fuse.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>