Skip to content
Snippets Groups Projects
Commit e07f281f authored by George Politis's avatar George Politis
Browse files

Adds Javadoc and fixes comments.

parent 7f39f556
No related branches found
No related tags found
No related merge requests found
......@@ -9,24 +9,32 @@
import net.sf.fmj.media.rtp.*;
/**
* Created by gp on 7/2/14.
*/
* Implements an <tt>RTCPReportBuilder</tt> which delegates its calls to a
* specific <tt>RTCPReportBuilder</tt>. If a delegate is not specified, then
* this class delegates its calls to an <tt>DefaultRTCPReportBuilderImpl</tt>
* instance.
*
* This class can be used to change the RTCP termination strategy during the
* run-time.
*
* @author George Politis
*/
class DelegatingRTCPReportBuilder
implements RTCPReportBuilder
{
/**
*
* Delegate <tt><RTCPReportBuilder/tt>.
*/
private RTCPReportBuilder delegate;
/**
*
* Fallback <tt><RTCPReportBuilder/tt>.
*/
private final RTCPReportBuilder fallback =
new DefaultRTCPReportBuilderImpl(); // TODO configurable?
new DefaultRTCPReportBuilderImpl();
/**
*
* The <tt>RTCPTransmitter</tt> of this <tt>RTCPReportBuilder</tt>.
*/
private RTCPTransmitter rtcpTransmitter;
......@@ -40,8 +48,7 @@ public void setDelegate(RTCPReportBuilder delegate)
}
/**
*
* @return
* {@inheritDoc}
*/
@Override
public RTCPPacket[] makeReports()
......@@ -58,7 +65,7 @@ public RTCPPacket[] makeReports()
}
/**
*
* {@inheritDoc}
*/
@Override
public void reset()
......@@ -73,8 +80,7 @@ public void reset()
}
/**
*
* @param rtcpTransmitter
* {@inheritDoc}
*/
@Override
public void setRTCPTransmitter(RTCPTransmitter rtcpTransmitter)
......@@ -86,6 +92,9 @@ public void setRTCPTransmitter(RTCPTransmitter rtcpTransmitter)
}
}
/**
* {@inheritDoc}
*/
@Override
public RTCPTransmitter getRTCPTransmitter()
{
......@@ -93,7 +102,7 @@ public RTCPTransmitter getRTCPTransmitter()
}
/**
*
* Notifies this instance that {@link #rtcpTransmitter} has changed.
*/
private void onRTCPTransmitterChanged()
{
......@@ -107,7 +116,7 @@ private void onRTCPTransmitterChanged()
}
/**
*
* Notifies this instance that {@link #delegate} has changed.
*/
private void onDelegateChanged()
{
......
......@@ -15,7 +15,12 @@
import org.jitsi.util.*;
/**
* Created by gp on 7/1/14.
* Uses the <tt>RTCPPacketTransformer</tt> of the
* <tt>RTCPTerminationStrategy</tt> of the <tt>RTPTranslator</tt> of the
* associated <tt>MediaStream</tt> to transform incoming RTCP packets. Advanced
* RTCP termination strategies can drop incoming RTCP packets.
*
* @author George Politis
*/
public class RTCPTerminationTransformEngine
extends SinglePacketTransformer
......@@ -24,28 +29,46 @@ public class RTCPTerminationTransformEngine
private static final Logger logger
= Logger.getLogger(RTCPTerminationTransformEngine.class);
/**
* The associated <tt>MediaStream</tt> of this
* <tt><RTCPTerminationTransformEngine/tt>.
*/
private final MediaStream mediaStream;
private final RTCPPacketParserEx parser;
/**
* Ctor.
*
* @param mediaStream
*/
public RTCPTerminationTransformEngine(MediaStream mediaStream)
{
this.mediaStream = mediaStream;
this.parser = new RTCPPacketParserEx();
}
/**
* {@inheritDoc}
*/
@Override
public void close()
{
// Nothing to do here.
}
/**
* {@inheritDoc}
*/
@Override
public PacketTransformer getRTCPTransformer()
{
return this;
}
/**
* {@inheritDoc}
*/
@Override
public PacketTransformer getRTPTransformer()
{
......@@ -53,6 +76,9 @@ public PacketTransformer getRTPTransformer()
return null;
}
/**
* {@inheritDoc}
*/
@Override
public RawPacket reverseTransform(RawPacket pkt)
{
......@@ -60,7 +86,8 @@ public RawPacket reverseTransform(RawPacket pkt)
if (pkt == null)
return pkt;
// Get the RTCP strategy.
// Get the RTCP termination strategy from the assiciated media stream
// translator.
RTPTranslator rtpTranslator = mediaStream.getRTPTranslator();
if (rtpTranslator == null)
return pkt;
......@@ -74,6 +101,9 @@ public RawPacket reverseTransform(RawPacket pkt)
RTCPPacketTransformer rtcpPacketTransformer
= rtcpTerminationStrategy.getRTCPPacketTransformer();
if (rtcpPacketTransformer == null)
return pkt;
// Parse the RTCP packet.
RTCPCompoundPacket inRTCPPacket;
try
......@@ -136,6 +166,9 @@ public RawPacket reverseTransform(RawPacket pkt)
return pktOut;
}
/**
* {@inheritDoc}
*/
@Override
public RawPacket transform(RawPacket pkt)
{
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment