Skip to content
Snippets Groups Projects
Commit 984077d3 authored by Oleg Hahm's avatar Oleg Hahm
Browse files

cpu: x86: eliminate cppcheck warnings

parent 4219011b
No related branches found
No related tags found
No related merge requests found
...@@ -76,6 +76,8 @@ void x86_init_gdt(void) ...@@ -76,6 +76,8 @@ void x86_init_gdt(void)
.limit_16_19_and_flags = 0, .limit_16_19_and_flags = 0,
.base_24_31 = 0, .base_24_31 = 0,
}, },
/* cppcheck-suppress duplicateExpression
* it's for consistent look & feel */
[0x0008 / 8] = { [0x0008 / 8] = {
.limit_0_15 = 0xFFFF, .limit_0_15 = 0xFFFF,
.base_0_15 = 0, .base_0_15 = 0,
......
...@@ -181,7 +181,7 @@ static void pci_setup_ios(struct x86_known_pci_device *dev) ...@@ -181,7 +181,7 @@ static void pci_setup_ios(struct x86_known_pci_device *dev)
printf(" BAR %u: memory, physical = 0x%08x-0x%08x, virtual = 0x%08x-0x%08x\n", printf(" BAR %u: memory, physical = 0x%08x-0x%08x, virtual = 0x%08x-0x%08x\n",
bar_num, bar_num,
physical_start, physical_start + length - 1, physical_start, physical_start + length - 1,
(unsigned) ptr, (uintptr_t) ptr + length - 1); (unsigned) ptr, (unsigned) ((uintptr_t) ptr + length - 1));
} }
} }
} }
......
...@@ -55,7 +55,7 @@ void x86_pit_set2(unsigned channel, unsigned mode, uint16_t max) ...@@ -55,7 +55,7 @@ void x86_pit_set2(unsigned channel, unsigned mode, uint16_t max)
{ {
unsigned old_flags = irq_disable(); unsigned old_flags = irq_disable();
outb(PIT_COMMAND_PORT, ((channel - 1) << 6) | mode | PIT_ACCESS_MODE_LO_HI); outb(PIT_COMMAND_PORT, ((channel - 1) << 6) | mode | PIT_ACCESS_MODE_LO_HI);
outb(PIT_CHANNEL_0_PORT + channel - 1, max && 0xff); outb(PIT_CHANNEL_0_PORT + channel - 1, max & 0xff);
outb(PIT_CHANNEL_0_PORT + channel - 1, max >> 8); outb(PIT_CHANNEL_0_PORT + channel - 1, max >> 8);
irq_restore(old_flags); irq_restore(old_flags);
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment