Signed-off-by: Or Cohen <orc@fewbytes.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

m_print() used special format specifiers from BSD's printf(9).

http://www.unix.com/man-page/freebsd/9/printf/



Instead of re-implementing these specifiers in different ways and
because this method is not being used anywhere, it was completely
removed.

Signed-off-by: Or Cohen <orc@fewbytes.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

ether_sprintf() used special format specifiers from BSD's printf(9).

http://www.unix.com/man-page/freebsd/9/printf/



Instead of re-implementing these specifiers in different ways and
because this method is not being used anywhere, it was completely
removed.

Signed-off-by: Or Cohen <orc@fewbytes.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

When building with -O0 we get:

 bsd/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.o: In
 function `zfs_ioc_destroy_snaps_nvl':
 (...)/bsd/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c:3265:
 undefined reference to `zvol_remove_minor'

Looks like the problem is that the missing symbol,
`zvol_remove_minor', referenced from zfs_ioctl.o is not in the zvol.o
because it's not defined, because it is inside '#ifdef NOTYET' block
(which is off). It works in the normal build because when compiled
with -O2 (and even with -O1), the reference to zvol_remove_minor in
zfs_ioctl.c is optimized away.

This patch puts the block using zvol_remove_minor also inside '#ifdef
NOTYET' to be consistent.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

FreeBSD networking code limits IP datagram size by IP_MAXPACKET
which is exactly 64K. This calculation doesn't take into account
Ethernet header length and may generate Ethernet packet longer than 64K.

Such a packet cannot be processed properly by some devices (Xen netback)
and being dropped.

This patch fixes this corner case for all supported IP protocols.

Signed-off-by: Dmitry Fleytman <dmitry@daynix.com>

This patch fixes part of TCP instability/low throughput problems on Xen.

On transmit networking stack passes to Xen netfront driver a list of mbufs
of up to PAGE_SIZE (4096) bytes each.
In case the list consists of more than MAX_TX_REQ_FRAGS (18) fragments
driver tries to defragment it with m_defrag().

m_defrag() in turn tries to build list of buffers of up to MCLBYTES
(2048) bytes each. This leads to even longer chain and packet being dropped.
As a result around 1% of TCP segments are lost and intensive TCP
retransmissions and slowdowns occur.

This patch makes m_defrag() use Jumbo packets zone for allocation, i.e.
PAGE_SIZE per mbuf.

This patch is pretty similar to what Glauber done on RX path before.

Signed-off-by: Dmitry Fleytman <dmitry@daynix.com>

Not supported on osv, and reported to break the build on some systems.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Make the two definitions exactly equal so the compiler does not complain.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

The 'define' form with '=' was introduced in GNU Make 3.82
and has the same meaning as without.

The default 'make' in Ubuntu 13.04 is stil on 3.81. Let's
drop '=' for better compatibility.

Symptoms:
 make[1]: Entering directory `~/src/osv/build/release'
      CC bsd/cddl/contrib/opensolaris/cmd/zpool/zpool_iter.o
    ../../bsd/cddl/contrib/opensolaris/cmd/zpool/zpool_iter.c:28:21:\
 fatal error: solaris.h: No such file or     directory
     #include <solaris.h>
                         ^
    compilation terminated.

Signed-off-by: Tomasz Grabiec <tgrabiec@cloudius-systems.com>

Fixes the following compilation error:

  ../../bsd/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c: In function ‘rw_enter’:
  ../../bsd/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c:205:3: error: pointer targets in passing argument 1 of ‘atomic_add_int’ differ in signedness [-Werror=pointer-sign]
     atomic_add_int(&rwlp->rw_count, 1);
     ^
  In file included from ../../bsd/sys/cddl/compat/opensolaris/sys/atomic.h:33:0,
                   from ../../bsd/cddl/contrib/opensolaris/lib/libzpool/common/sys/zfs_context.h:66,
                   from ../../bsd/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/spa.h:31,
                   from ../../bsd/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c:32:
  ../../bsd/machine/atomic.h:285:1: note: expected ‘volatile u_int *’ but argument is of type ‘int *’
   ATOMIC_ASM(add,      int,   "addl %1,%0",  "ir",  v);
   ^

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Fixes the following build breakage:

    CC bsd/cddl/contrib/opensolaris/lib/libzpool/common/kernel.o
  ../../bsd/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c: In function ‘cv_timedwait’:
  ../../bsd/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c:322:2: error: implicit declaration of function ‘gettimeofday’ [-Werror=implicit-function-declaration]
    if (gettimeofday(&tv, NULL) != 0)
  ^
  cc1: all warnings being treated as errors

Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

root mounts accept both a device and a pool name, while non-root mounts
only accept the pool name (the device(s) already known while mounting the pool
during the root mount).

Adjust the mount protocol for this.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

A zpool has a zfs as its userspace interface; but the call to create it was
disabled as part of the porting effort.

Re-enable it so osv can create zpools.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

To build is_whole_disk() we need to pull in a lot of partition code.

Ignore it instead.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

MNTTAB points at /dev/zero, which doesn't exist, and is too long anyway.

Point it at the correct place.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

MAXPATHLEN on osv is larger than on bsd, leading to the zfs ioctl command
buffer overflowing the maximum allowable size.

Reduce the buffer size to avoid a compile time assert failure.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

This is a shortcut through various kernel layers to avoid complication,
intended to be called from the various zfs utilities.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Not supported under osv.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Wanted by zfs_ioctl.c.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>