Skip to content
Snippets Groups Projects
  1. Aug 17, 2017
  2. Jul 01, 2017
  3. Jun 27, 2017
  4. Jun 15, 2017
  5. May 24, 2017
  6. May 22, 2017
    • Stepan Koltsov's avatar
      Optimize Bytes::slice(n, n) (#123) · 3f5890be
      Stepan Koltsov authored
      Return empty `Bytes` object
      
      Bench for `slice_empty` difference is
      
      ```
      55 ns/iter (+/- 1) # before this patch
      17 ns/iter (+/- 5) # with this patch
      ```
      
      Bench for `slice_not_empty` is
      
      ```
      25,058 ns/iter (+/- 1,099) # before this patch
      25,072 ns/iter (+/- 1,593) # with this patch
      ```
      3f5890be
  7. May 15, 2017
    • Stepan Koltsov's avatar
      BytesMut::reserve should not overallocate (#117) · 7110d57b
      Stepan Koltsov authored
      Round up to power of 2 is not necessary, because `reserve` already
      doubles previous capacity in
      
      ```
      	new_cap = cmp::max(
      		cmp::max(v.capacity() << 1, new_cap),
      		original_capacity);
      ```
      
      which makes `reserve` calls constant in average. Avoiding rounding
      up prevents `reserve` from wasting space when caller knows exactly
      what space they need.
      
      Patch adds three tests which would fail before this test. The most
      important is this:
      
      ```
      #[test]
      fn reserve_in_arc_unique_does_not_overallocate() {
          let mut bytes = BytesMut::with_capacity(1000);
          bytes.take();
      
          // now bytes is Arc and refcount == 1
      
          assert_eq!(1000, bytes.capacity());
          bytes.reserve(2001);
          assert_eq!(2001, bytes.capacity());
      }
      ```
      
      It asserts that when user requests more than double of current
      capacity, exactly the requested amount of memory is allocated and
      is not wasted to next power of two.
      7110d57b
    • Stepan Koltsov's avatar
      Bytes::extend_from_slice (#120) · 07db74b0
      Stepan Koltsov authored
      `extend_with_slice` is super-convenient operation on `Bytes`.
      
      While `put_u8` would be expensive on `Bytes`, `extend_from_slice`
      is OK, because it is batch, and it checks for kind only once.
      
      Patch also adds `impl Extend for Bytes`.
      
      cc #116
      07db74b0
  8. May 02, 2017
  9. Apr 30, 2017
  10. Mar 30, 2017
    • Carl Lerche's avatar
      Bytes: only the vec repr is not shared (#100) · 9aa24ebe
      Carl Lerche authored
      The shared debug_assert is to ensure that the internal Bytes
      representation is such that offset views are supported. The only
      representation that does not support offset views is vec.
      
      Fixes #97
      9aa24ebe
  11. Mar 28, 2017
    • Stepan Koltsov's avatar
    • Stepan Koltsov's avatar
      Handle corner cases of Bytes::split_{off,to} (#87) · b78bb3ba
      Stepan Koltsov authored
      Before this commit `Bytes::split_{off,to}` always created a shallow copy if `self` is arc or vec.
      
      However, in certain cases `split_off` or `split_to` is called with `len` or `0` parameter. E. g. if you are reading a frame from buffered stream, it is likely that buffer contains exactly the frame size bytes, so `split_to` will be called with `len` param.
      
      Although, `split_off` and `split_to` functions are `O(1)`, shallow copy have downsides:
      
      * shallow copy on vector does malloc and atomic cmpxchg
      * after shallow copy, following operations (e. g. `drop`) on both `bytes` objects require atomics
      * memory will be probably released to the system later
      * `try_mut` will fail
      * [into_vec](https://github.com/carllerche/bytes/issues/86) will copy
      b78bb3ba
  12. Mar 21, 2017
    • Stepan Koltsov's avatar
      Reimplement fmt::Debug for Bytes and BytesMut (#84) · 613d4bd5
      Stepan Koltsov authored
      Standard `Debug` implementation for `[u8]` is comma separated list
      of numbers. Since large amount of byte strings are in fact ASCII
      strings or contain a lot of ASCII strings (e. g. HTTP), it is
      convenient to print strings as ASCII when possible.
      613d4bd5
  13. Mar 20, 2017
    • Carl Lerche's avatar
      Misc CI fixes (#89) · dc9c8e30
      Carl Lerche authored
      Limit the number of threads when using qemu to 1. Also, don't bother
      running the stress test as this will trigger qemu bugs. Finally, also
      make the stress test actually stress test.
      dc9c8e30
  14. Mar 19, 2017
  15. Mar 07, 2017
  16. Mar 03, 2017
    • Carl Lerche's avatar
      `BytesMut::reserve` should avoid small allocations · 933b8b26
      Carl Lerche authored
      This change tracks the original capacity requested when `BytesMut` is
      first created. This capacity is used when a `reserve` needs to allocate
      due to the current view being too small. The newly allocated buffer will
      be sized the same as the original allocation.
      933b8b26
  17. Mar 02, 2017
  18. Mar 01, 2017
  19. Feb 21, 2017
  20. Feb 20, 2017
    • Carl Lerche's avatar
      Rewrite `Bytes` / `BytesMut` core implementation · cf5a1bc4
      Carl Lerche authored
      The previous implementation didn't factor in a single `Bytes` handle
      being stored in an `Arc`. This new implementation correctly impelments
      both `Bytes` and `BytesMut` such that both are `Sync`.
      
      The rewrite also increases the number of bytes that can be stored
      inline.
      cf5a1bc4
  21. Feb 17, 2017
  22. Feb 16, 2017
  23. Feb 15, 2017
  24. Jan 26, 2017
  25. Nov 21, 2016
  26. Nov 02, 2016
    • Carl Lerche's avatar
      Restructure and trim down the library · 57e84f26
      Carl Lerche authored
      This commit is a significant overhaul of the library in an effort to head
      towards a stable API. The rope implementation as well as a number of buffer
      implementations have been removed from the library and will live at
      https://github.com/carllerche/bytes-more while they incubate.
      
      **Bytes / BytesMut**
      
      `Bytes` is now an atomic ref counted byte slice. As it is contigous, it offers
      a richer API than before.
      
      `BytesMut` is a mutable variant. It is safe by ensuring that it is the only
      handle to a given byte slice.
      
      **AppendBuf -> ByteBuf**
      
      `AppendBuf` has been replaced by `ByteBuf`. The API is not identical, but is
      close enough to be considered a suitable replacement.
      
      **Removed types**
      
      The following types have been removed in favor of living in bytes-more
      
      * RingBuf
      * BlockBuf
      * `Bytes` as a rope implementation
      * ReadExt
      * WriteExt
      57e84f26
Loading