MAXPATHLEN on osv is larger than on bsd, leading to the zfs ioctl command
buffer overflowing the maximum allowable size.

Reduce the buffer size to avoid a compile time assert failure.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

This is a shortcut through various kernel layers to avoid complication,
intended to be called from the various zfs utilities.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Not supported under osv.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Wanted by zfs_ioctl.c.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Make it part of libzfs, we don't need it separately anyway.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Strangely, it still works even though it's not initialized.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Fixed MAXPATHLEN

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Needed by libzfs.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

We have _KERNEL defines scattered throughout the code, which makes
understanding it difficult.

Define it just once, and adjust the source to build.

We define it in an overridable variable, so that non-kernel imported code
can undo it.

Imported from FreeBSD 245655, no changes.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Import FreeBSD files, changeset 245655.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Imported with no change from FreeBSD 245655.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Imported with no change from FreeBSD 245655.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

Signed-off-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Avi Kivity <avi@cloudius-systems.com>

bsd's ifconf conflicts with osv's; rename it.

We use the bsd version in <osv/ioctl.h>, since we currently don't support
the Linux-ABI variants of these ioctls.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Tested-By: Benoit Canet <benoit@irqsave.net>

The bsd ifaddr struct conflicts with the osv ifaddr struct, which is a
public interface.  Rename the bsd struct to avoid conflict.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Tested-By: Benoit Canet <benoit@irqsave.net>

Workaround a bytorder function conflict, and reconcile a declaration.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Tested-By: Benoit Canet <benoit@irqsave.net>

Some structures are duplicated; move the duplicates to a common header
<netinet/__in.h>.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Tested-By: Benoit Canet <benoit@irqsave.net>

Some structures are duplicated; deduplicate them.

A few are source-compatible but not binary-compatible; use the ones from
<bits/socket.h>.

Others are both source- and binary- compatible; put them in a new header
<sys/__socket.h> which is included from both.

Work around a problem with the byteorder functions/macros.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Tested-By: Benoit Canet <benoit@irqsave.net>

Update ->va_nlink() in zfs_getattr() in preparation for sys_link().

Signed-off-by: Raphael S. Carvalho <raphael.scarv@gmail.com>
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

Wire up the VOP_LINK vnode operation for ZFS in preparation for
sys_link().

Signed-off-by: Raphael S. Carvalho <raphael.scarv@gmail.com>
[ penberg: drop FIGNORE, cleanup, split ]
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>

All the other fields of the pcpu structure BSD expects are initialized by
the event channel. Except for the cpu id, which the code expects to be already
initialized.

Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>

Right now we send route messages with MTUs zeroed out. This can lead
to the following assert in ip_output.c (~line 308) triggering:

    KASSERT(mtu > 0, ("%s: mtu %d <= 0, rte=%p (rt_flags=0x%08x) ifp=%p",
        __func__, mtu, rte, (rte != NULL) ? rte->rt_flags : 0, ifp));

This happens because the code will assume that if there is a valid route, that
route will have a valid MTU. And in this case, will always use the route MTU
instead of the interface one.

When we allocate the route it has a valid MTU. But when we send the route
message, we will overwrite it with the value we see in the route message.  This
is done in rtsock.c:rt_setmetrics.

With this patch, those assertion stops happening.

A note: this wasn't been seen in local instalations, only on EC2. Looking at
it, there is nothing Xen specific. The reason it was not happening on local, is
that local traffic does not go through the default route, but rather through
the local 192.168.100.0/24 route. That one seems to take a different
configuration path, and thus sets the MTU correctly.

Added our copyright statements to some of the files in the top bsd/
directory, and in bsd/porting.

I only added our copyright to files which were completely by us - I did
not attempt to hunt which bsd or solaris files we modified to add our
copyright to them, I don't think this is important (or, we can do this
later).

I also found one header file (uma_stub.h) that had large chunks copied from
freebsd, so I added both the freebsd copyright and ours.

* %lu => %u when reading flush. The barrier flag had the same bug, but I
ended up recreating it for flush.
* Move check of xb_flags to after we check sc->flags != NULL, as spotted by
Dima

Not all Xen versions implement the barrier feature in their pv disks. Such is
the case in Amazon EC2. For those, we should interpret the flush request and
wait for the requests until they are all handled. Also, we can still try to use
one of either barriers or flush-disk operations before we resort to guest-side
software implementation. Our driver currently only tests for one of them, so
this patch also implements flush requests.

Luckily, the implementation of xb_dump (which we don't currently use) needs to
do that as well, and this is also quite well isolated in xb_quiesce(). All we need
to do is call xb_quiesce() if flushing is not available in our backend

Even Lords make brown paper bag mistakes. This is a left over code from my
initial testing, where the buffer where set with pre existing values to make
sure they were going through.  I forgot to remove them. As a result reads were
fine, but writes would just wipe the previous data from the buffer.
Incidentally, the "write-then-read-the-data-back" test I was doing would also
obviously pass, so I haven't noticed this so far.

Fix is to just leave the buffer alone.

msleep() measure times in units of 1/hz seconds. We had hz = 1,000,000,
which gives excellent resolution (microsecond) but a terible range
(limits msleep()'s timeout to 35 minutes).

We had a program (Cassandra) doing poll() with a timeout of 2 hours,
which caused msleep to think we gave a negative timeout.

This patch reduces hz to 1,000, i.e., have msleep() operate in the same units
as poll(). Looking at the code, I don't believe this change will have any
ill-effects - we don't need higher resolution (freebsd code is used to
hz=1,000, which is the default there), and the code converts time units to
hz's correctly, always using the hz macro. The allowed range for timeouts will
grow to over 24 days - and match poll()'s allowed range.