Skip to content
Snippets Groups Projects
  1. Mar 30, 2017
    • Carl Lerche's avatar
      Bytes: only the vec repr is not shared (#100) · 9aa24ebe
      Carl Lerche authored
      The shared debug_assert is to ensure that the internal Bytes
      representation is such that offset views are supported. The only
      representation that does not support offset views is vec.
      
      Fixes #97
      9aa24ebe
  2. Mar 28, 2017
    • Stepan Koltsov's avatar
    • Stepan Koltsov's avatar
      Handle corner cases of Bytes::split_{off,to} (#87) · b78bb3ba
      Stepan Koltsov authored
      Before this commit `Bytes::split_{off,to}` always created a shallow copy if `self` is arc or vec.
      
      However, in certain cases `split_off` or `split_to` is called with `len` or `0` parameter. E. g. if you are reading a frame from buffered stream, it is likely that buffer contains exactly the frame size bytes, so `split_to` will be called with `len` param.
      
      Although, `split_off` and `split_to` functions are `O(1)`, shallow copy have downsides:
      
      * shallow copy on vector does malloc and atomic cmpxchg
      * after shallow copy, following operations (e. g. `drop`) on both `bytes` objects require atomics
      * memory will be probably released to the system later
      * `try_mut` will fail
      * [into_vec](https://github.com/carllerche/bytes/issues/86) will copy
      b78bb3ba
  3. Mar 24, 2017
  4. Mar 21, 2017
    • Stepan Koltsov's avatar
      Reimplement fmt::Debug for Bytes and BytesMut (#84) · 613d4bd5
      Stepan Koltsov authored
      Standard `Debug` implementation for `[u8]` is comma separated list
      of numbers. Since large amount of byte strings are in fact ASCII
      strings or contain a lot of ASCII strings (e. g. HTTP), it is
      convenient to print strings as ASCII when possible.
      613d4bd5
  5. Mar 19, 2017
    • Carl Lerche's avatar
      Clarify when `BufMut::bytes_mut` can return &[] · bed128b2
      Carl Lerche authored
      Closes #79
      bed128b2
    • Dan Burkert's avatar
      Add inline attributes to Vec's MutBuf methods (#80) · 5a265cc8
      Dan Burkert authored
      I found this significantly improved a
      [benchmark](https://gist.github.com/danburkert/34a7d6680d97bc86dca7f396eb8d0abf)
      which calls `bytes_mut`, writes 1 byte, and advances the pointer with
      `advance_mut` in a pretty tight loop. In particular, it seems to be the
      inline annotation on `bytes_mut` which had the most effect. I also took
      the opportunity to simplify the bounds checking in advance_mut.
      
      before:
      
      ```
      test encode_varint_small  ... bench:         540 ns/iter (+/- 85) = 1481 MB/s
      ```
      
      after:
      
      ```
      test encode_varint_small  ... bench:         422 ns/iter (+/- 24) = 1895 MB/s
      ```
      
      As you can see, the variance is also significantly improved.
      
      Interestingly, I tried to change the last statement in `bytes_mut` from
      
      ```
      &mut slice::from_raw_parts_mut(ptr, cap)[len..]
      ```
      
      to
      
      ```
      slice::from_raw_parts_mut(ptr.offset(len as isize), cap - len)
      ```
      
      but, this caused a very measurable perf regression (almost completely
      negating the gains from marking bytes_mut inline).
      5a265cc8
    • Dan Burkert's avatar
      Clarify BufMut::advance_mut docs (#78) · 4fe4e942
      Dan Burkert authored
      Also fixes an issue with a line wrap in the middle of an inline code
      block.
      4fe4e942
  6. Mar 16, 2017
  7. Mar 07, 2017
  8. Mar 03, 2017
    • Carl Lerche's avatar
      `BytesMut::reserve` should avoid small allocations · 933b8b26
      Carl Lerche authored
      This change tracks the original capacity requested when `BytesMut` is
      first created. This capacity is used when a `reserve` needs to allocate
      due to the current view being too small. The newly allocated buffer will
      be sized the same as the original allocation.
      933b8b26
  9. Mar 02, 2017
  10. Mar 01, 2017
  11. Feb 28, 2017
  12. Feb 21, 2017
  13. Feb 20, 2017
  14. Feb 17, 2017
  15. Feb 16, 2017
  16. Feb 15, 2017
Loading